Fix flashing window when deleting profile

Fix flashing window when deleting profile

Deleting a profile with the sync promo open would cause the delete profile's browser window to temporarily re-open.

The problem was that the sync promo was attempting to navigate to a page when the promo was closed. Fix was to disable the navigation if the browser window was being closed.

BUG=108801
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118710

[sail, 2012-01-23 05:12:43]

rsesek, sky: could you please take a look. My solution isn't very good. If you
could recommend a more general solution that would be nice.

For example, could I put this check inside Browser::OpenURLFromTab() instead?

Thanks!

[sky, 2012-01-23 16:09:54]

'attemptingToClose' can be set in various places so I don't think it's wise to
make Browser::OpenURL ignore requests when attempingToClose. This seems fine to
me.

https://chromiumcodereview.appspot.com/9193004/diff/1/chrome/browser/ui/webui...
File chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc (right):

https://chromiumcodereview.appspot.com/9193004/diff/1/chrome/browser/ui/webui...
chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc:204:
BrowserList::FindBrowserWithWebContents(web_ui()->GetWebContents());
Add a comment as to why you need this.

[sail, 2012-01-23 17:06:56]

https://chromiumcodereview.appspot.com/9193004/diff/1/chrome/browser/ui/webui...
File chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc (right):

https://chromiumcodereview.appspot.com/9193004/diff/1/chrome/browser/ui/webui...
chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc:204:
BrowserList::FindBrowserWithWebContents(web_ui()->GetWebContents());
On 2012/01/23 16:09:54, sky wrote:
> Add a comment as to why you need this.

Done.

[sky, 2012-01-23 17:27:25]

LGTM

[commit-bot: I haz the power, 2012-01-23 17:34:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/9193004/6003

[commit-bot: I haz the power, 2012-01-23 17:34:25]

Presubmit check for 9193004-6003 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc

[sail, 2012-01-23 17:35:25]

jhawkins: Do I need to make this change to sync_promo_handler2.cc as well?

[James Hawkins, 2012-01-23 17:37:41]

Yes, though this mess will be cleaned up shortly.

[sail, 2012-01-23 17:46:46]

On 2012/01/23 17:37:41, James Hawkins wrote:
> Yes, though this mess will be cleaned up shortly.

Ahh, sounds good. Updated, please take a look.

[James Hawkins, 2012-01-23 17:48:04]

lgtm

[commit-bot: I haz the power, 2012-01-23 17:50:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/9193004/3

[commit-bot: I haz the power, 2012-01-23 19:10:42]

Change committed as 118710