Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 9192038: Relanding this with fixes to the mac dbg builder (Closed)

Created:
8 years, 11 months ago by ananta
Modified:
8 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, brettw-cc_chromium.org, darin-cc_chromium.org, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Relanding this with fixes to the mac dbg builder Remove the Webkit thread in the PPAPI plugin process and perform the text and font operations on the PPAPI main thread. This thread is now registered as the Webkit thread. Fixes performance issues seen in Flapper with text and font operations. It appears that the perf issues occur due to context switching between the main thread and the webkit thread. As per comments from Brett moving the font forwarding code inline to ppb_font_shared.cc. This file has been moved to ppapi/shared_impl/private as it now brings in a dependency on WebKit. The font creation has been wired up to the ResourceCreationAPI as suggested. BUG=110190 TBR=brettw Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118503

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+517 lines, -1013 lines) Patch
M chrome/renderer/chrome_ppb_pdf_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_ppapi_plugin.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.h View 3 chunks +4 lines, -9 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 5 chunks +5 lines, -15 lines 0 comments Download
D content/ppapi_plugin/ppapi_webkit_thread.h View 1 1 chunk +0 lines, -50 lines 0 comments Download
D content/ppapi_plugin/ppapi_webkit_thread.cc View 1 1 chunk +0 lines, -44 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 2 3 4 5 4 chunks +15 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/plugin_proxy_delegate.h View 1 chunk +0 lines, -10 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M ppapi/proxy/ppb_font_proxy.h View 2 chunks +0 lines, -50 lines 0 comments Download
M ppapi/proxy/ppb_font_proxy.cc View 3 chunks +2 lines, -180 lines 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.h View 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/proxy/ppb_image_data_proxy.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 2 chunks +6 lines, -4 lines 0 comments Download
D ppapi/shared_impl/ppb_font_shared.h View 1 1 chunk +0 lines, -32 lines 0 comments Download
D ppapi/shared_impl/ppb_font_shared.cc View 1 1 chunk +0 lines, -35 lines 0 comments Download
A + ppapi/shared_impl/private/ppb_font_shared.h View 1 2 chunks +44 lines, -4 lines 0 comments Download
A + ppapi/shared_impl/private/ppb_font_shared.cc View 1 2 chunks +385 lines, -1 line 0 comments Download
M ppapi/shared_impl/webkit_forwarding.h View 2 chunks +5 lines, -24 lines 0 comments Download
M ppapi/thunk/ppb_font_api.h View 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/thunk/ppb_image_data_api.h View 2 chunks +7 lines, -0 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.h View 2 chunks +0 lines, -6 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M webkit/plugins/ppapi/ppb_flash_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/ppb_font_impl.h View 3 chunks +4 lines, -39 lines 0 comments Download
M webkit/plugins/ppapi/ppb_font_impl.cc View 2 chunks +4 lines, -138 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_2d_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_image_data_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppb_image_data_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_scrollbar_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.cc View 4 chunks +8 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/resource_helper.h View 2 chunks +4 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/resource_helper.cc View 1 chunk +6 lines, -1 line 0 comments Download
D webkit/plugins/ppapi/webkit_forwarding_impl.h View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
D webkit/plugins/ppapi/webkit_forwarding_impl.cc View 1 2 1 chunk +0 lines, -300 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698