Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 9192037: Remove dangling chrome://theme/IDR_CLOSE_BAR* references (Closed)

Created:
8 years, 11 months ago by benrg
Modified:
8 years, 11 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv (Not doing code reviews), nkostylev+watch_chromium.org, xiyuan
Visibility:
Public.

Description

Hack: remove dangling chrome://theme/IDR_CLOSE_BAR* references In issue 9187061 I stupidly overlooked some references to these moved assets (close box images). This change will cause them to appear again by replacing the chrome:// references with paths to the PNG images. These paths are turned into data references during the build process, which will add a few kilobytes to the executable size (the images are 125-227 bytes each). What should be done instead is to update the ThemeSource to find the assets in the new location. This is a temporary fix until that happens. BUG=110824, 110828 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118520

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M chrome/browser/resources/chromeos/login/user_pod_row.css View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.css View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/chromeos/accounts_options_page.css View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/accounts_options_page.css View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/shared/css/bubble.css View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/shared/css/expandable_bubble.css View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
benrg
This is the easy way out...
8 years, 11 months ago (2012-01-20 02:12:57 UTC) #1
Evan Stade
lgtm
8 years, 11 months ago (2012-01-20 02:32:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benrg@chromium.org/9192037/1
8 years, 11 months ago (2012-01-20 02:32:45 UTC) #3
commit-bot: I haz the power
Try job failure for 9192037-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 11 months ago (2012-01-20 04:25:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benrg@chromium.org/9192037/1
8 years, 11 months ago (2012-01-20 05:17:19 UTC) #5
commit-bot: I haz the power
Try job failure for 9192037-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 11 months ago (2012-01-20 07:02:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benrg@chromium.org/9192037/1
8 years, 11 months ago (2012-01-20 17:26:57 UTC) #7
commit-bot: I haz the power
Try job failure for 9192037-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 11 months ago (2012-01-20 19:17:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benrg@chromium.org/9192037/1
8 years, 11 months ago (2012-01-20 20:11:52 UTC) #9
commit-bot: I haz the power
8 years, 11 months ago (2012-01-20 22:18:49 UTC) #10
Change committed as 118520

Powered by Google App Engine
This is Rietveld 408576698