Bindings layer for declarative events API

chrome/renderer/resources/extensions/schema_generated_bindings.js

Index: chrome/renderer/resources/extensions/schema_generated_bindings.js
diff --git a/chrome/renderer/resources/extensions/schema_generated_bindings.js b/chrome/renderer/resources/extensions/schema_generated_bindings.js
index 413476272c462cfa1d4e332edc3ff488334285c4..604d57490771f988fd46b1412e38d1c02882ade3 100644
--- a/chrome/renderer/resources/extensions/schema_generated_bindings.js
+++ b/chrome/renderer/resources/extensions/schema_generated_bindings.js
@@ -455,14 +455,19 @@ var chrome = chrome || {};
             return;
           }
 
+          var typesAPI = {
+            'sendRequest': sendRequest,
+            'apiDefinitions': apiDefinitions
+          };

[Matt Perry, 2012/01/24 22:39:10]

If we need to expose these identifiers to other modules, lets just put them on
chromeHidden.

[battre, 2012/01/25 19:25:08]

That would be a bigger change because the same mechanism is used for all custom
bindings. I have renamed the dictionary to bindingsAPI, though, to be more in
line with the rest of the code.

[Matt Perry, 2012/01/25 22:29:35]

I don't understand. sendRequest and apiDefinitions are essentially globals. Why
can't we just do:

chromeHidden.sendRequest = sendRequest;
chromeHidden.apiDefinitions = apiDefinitions

[Aaron Boodman, 2012/01/31 00:11:17]

I kinda preferred it the way Dominic had it. Ben and James are in the process of
untangling this, and I think they want to move even more in the direction of
having explicit dependencies (they eventually want to be able to unit test these
js files outside of the v8::Extension system).

[battre, 2012/01/31 12:28:50]

Ok, I will wait for Ben's and James' call.

           var eventName = apiDef.namespace + "." + eventDef.name;
           var customEvent = customEvents[apiDef.namespace];
           if (customEvent) {
             module[eventDef.name] = new customEvent(
-                eventName, eventDef.parameters, eventDef.extraParameters);
+                eventName, eventDef.parameters, eventDef.extraParameters,
+                eventDef.options, typesAPI);
           } else {
             module[eventDef.name] = new chrome.Event(
-                eventName, eventDef.parameters);
+                eventName, eventDef.parameters, eventDef.options, typesAPI);
           }
         });
       }