Bindings layer for declarative events API

chrome/renderer/resources/extensions/schema_generated_bindings.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This script contains privileged chrome extension related javascript APIs.
 // It is loaded by pages whose URL has the chrome-extension protocol.
 
 var chrome = chrome || {};
 (function() {
   native function GetChromeHidden();
@@ skipping 437 matching lines @@
 
       // Setup Events
       if (apiDef.events) {
         apiDef.events.forEach(function(eventDef) {
           if (eventDef.name in module ||
               addUnprivilegedAccessGetter(module, eventDef.name,
                                           eventDef.unprivileged)) {
             return;
           }
 
+          var typesAPI = {
+            'sendRequest': sendRequest,
+            'apiDefinitions': apiDefinitions
+          };

[Matt Perry, 2012/01/24 22:39:10]

If we need to expose these identifiers to other modules, lets just put them on
chromeHidden.

[battre, 2012/01/25 19:25:08]

That would be a bigger change because the same mechanism is used for all custom
bindings. I have renamed the dictionary to bindingsAPI, though, to be more in
line with the rest of the code.

[Matt Perry, 2012/01/25 22:29:35]

I don't understand. sendRequest and apiDefinitions are essentially globals. Why
can't we just do:

chromeHidden.sendRequest = sendRequest;
chromeHidden.apiDefinitions = apiDefinitions

[Aaron Boodman, 2012/01/31 00:11:17]

I kinda preferred it the way Dominic had it. Ben and James are in the process of
untangling this, and I think they want to move even more in the direction of
having explicit dependencies (they eventually want to be able to unit test these
js files outside of the v8::Extension system).

[battre, 2012/01/31 12:28:50]

Ok, I will wait for Ben's and James' call.

           var eventName = apiDef.namespace + "." + eventDef.name;
           var customEvent = customEvents[apiDef.namespace];
           if (customEvent) {
             module[eventDef.name] = new customEvent(
-                eventName, eventDef.parameters, eventDef.extraParameters);
+                eventName, eventDef.parameters, eventDef.extraParameters,
+                eventDef.options, typesAPI);
           } else {
             module[eventDef.name] = new chrome.Event(
-                eventName, eventDef.parameters);
+                eventName, eventDef.parameters, eventDef.options, typesAPI);
           }
         });
       }
 
       function addProperties(m, def) {
         // Parse any values defined for properties.
         if (def.properties) {
           forEach(def.properties, function(prop, property) {
             if (prop in m ||
                 addUnprivilegedAccessGetter(m, prop, property.unprivileged)) {
@@ skipping 70 matching lines @@
     // See http://crbug.com/100242
     if (apiExists("webstorePrivate")) {
       chrome.webstorePrivate.beginInstallWithManifest2 =
           chrome.webstorePrivate.beginInstallWithManifest3;
     }
 
     if (apiExists("test"))
       chrome.test.getApiDefinitions = GetExtensionAPIDefinition;
   });
 })();