compiler/lib/implementation/bool.js - Issue 9192007: Simplify equality checks and get rid of unreachable code in number and bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/lib/implementation/bool.js

Issue 9192007: Simplify equality checks and get rid of unreachable code in number and bool. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: compiler/lib/implementation/bool.js

diff --git a/compiler/lib/implementation/bool.js b/compiler/lib/implementation/bool.js

index eebab247d65b405391354589e9133154b021abcc..7f7c08faabbf4d38cba5a5ee72631c82450dff58 100644

--- a/compiler/lib/implementation/bool.js

+++ b/compiler/lib/implementation/bool.js

@@ -3,7 +3,7 @@

// BSD-style license that can be found in the LICENSE file.

function native_BoolImplementation_EQ(other) {

- return typeof other == 'boolean' && this == other;

+ throw Error('UNREACHABLE');

}

function native_BoolImplementation_toString() {

« no previous file with comments | « no previous file | compiler/lib/implementation/core.js » ('j') | compiler/lib/implementation/core.js » ('J')