Simplify equality checks and get rid of unreachable code in number and bool.

compiler/lib/implementation/string.js

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 function native_StringImplementation__indexOperator(index) {
   "use strict";
   return this[index];
 }
 
 function native_StringImplementation__charCodeAt(index) {
   "use strict";
   return this.charCodeAt(index);
 }
 
 function native_StringImplementation_get$length() {
   "use strict";
   return this.length;
 }
 
 function native_StringImplementation_EQ(other) {
-  "use strict";
-  return typeof other == 'string' && this == other;
+  // TODO(kasperl): We should really try to avoid having wrapped
+  // strings floating around. The usually stem from referencing [this]

[mmendez, 2012/01/19 17:09:47]

Nit: the -> they.

+  // in Dart methods patched onto the String.prototype object.
+
+  // Because of the checks in EQ$operator, we know [this] is a string
+  // wrapper, but we have to make sure that [other] is either a
+  // wrapper or a proper string before we can use == to compare the
+  // contents.
+  return (typeof(other) == 'string' || other.constructor === String)
+      ? this == other
+      : false;
 }
 
 function native_StringImplementation__nativeIndexOf(other, startIndex) {
   "use strict";
   return this.indexOf(other, startIndex);
 }
 
 function native_StringImplementation__nativeLastIndexOf(other, fromIndex) {
   "use strict";
   if (other == "") {
@@ skipping 102 matching lines @@
     }
     array = tmp;
   }
   return String.fromCharCode.apply(this, array);
 }
 
 // Deprecated old name of new String.fromValues(..).
 function native_StringBase_createFromCharCodes(array) {
   return native_StringImplementation__newFromValues(array);
 }