Simplify equality checks and get rid of unreachable code in number and bool.

compiler/lib/implementation/core.js

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Helpers for lazy static initialization.
  */
 var static$uninitialized = {};
 var static$initializing = {};
 
@@ skipping 234 matching lines @@
  */
 var $Dart$Null = void 0;
 
 function assert(expr) {
   var val = typeof(expr) == 'function' ? $dartcall(expr, []) : expr;
   if (val !== true) {
     $Dart$ThrowException(native_ExceptionHelper_createAssertionError());
   }
 }
 
-// TODO(jimhug): Remove these functions after updating compiler backend.
 function BIT_OR$operator(val1, val2) {
   return (typeof(val1) == 'number' && typeof(val2) == 'number')
       ? val1 | val2
       : val1.BIT_OR$operator(val2);
 }
 
 function BIT_XOR$operator(val1, val2) {
   return (typeof(val1) == 'number' && typeof(val2) == 'number')
       ? val1 ^ val2
       : val1.BIT_XOR$operator(val2);
@@ skipping 61 matching lines @@
     return (tmp < 0) ? Math.ceil(tmp) : Math.floor(tmp);
   } else {
     return val1.TRUNC$operator(val2);
   }
 }
 
 function negate$operator(val) {
   return (typeof(val) == 'number') ? -val : val.negate$operator();
 }
 
+function EQ$operator(val1, val2) {
+  return (typeof val1 != 'object')

[floitsch, 2012/01/19 11:31:59]

what if val1 is a native string and val2 is a boxed string?

[kasperl, 2012/01/19 11:43:04]

Good point. This code behaves the same (broken) way as the old code and always
return false in this case. It seems that I've only fixed the case where you're
comparing two wrappers.

+      ? val1 === val2
+      : val1.EQ$operator(val2);
+}
+
+function NE$operator(val1, val2) {
+  return (typeof val1 != 'object')

[floitsch, 2012/01/19 11:31:59]

ditto.

+      ? val1 !== val2
+      : !val1.EQ$operator(val2);
+}
+
 function LT$operator(val1, val2) {
   return (typeof(val1) == 'number' && typeof(val2) == 'number')
       ? val1 < val2
       : val1.LT$operator(val2);
 }
 
 function GT$operator(val1, val2) {
   return (typeof(val1) == 'number' && typeof(val2) == 'number')
       ? val1 > val2
       : val1.GT$operator(val2);
 }
 
 function LTE$operator(val1, val2) {
   return (typeof(val1) == 'number' && typeof(val2) == 'number')
       ? val1 <= val2
       : val1.LTE$operator(val2);
 }
 
 function GTE$operator(val1, val2) {
   return (typeof(val1) == 'number' && typeof(val2) == 'number')
       ? val1 >= val2
       : val1.GTE$operator(val2);
 }
 
-
-/**
- * These operators need to work correctly with undefined
- * so must be functions.
- */
-function EQ$operator(val1, val2) {
-  if (val1 === $Dart$Null) {
-    return val2 === $Dart$Null;
-  } else if (typeof(val1) == typeof(val2) && typeof val1 != 'object') {
-    // number, boolean, string
-    return val1 === val2;
-  }
-  return val1.EQ$operator(val2);
-}
-
-function NE$operator(val1, val2) {
-  return !EQ$operator(val1, val2);
-}
-
 // The following operator-functions are not called from Dart-generated code, but
 // only from handwritten JS code.
 function INDEX$operator(obj, index) {
   return obj.INDEX$operator(index);
 }
 
 function ASSIGN_INDEX$operator(obj, index, newVal) {
   obj.ASSIGN_INDEX$operator(index, newVal);
 }
 
@@ skipping 137 matching lines @@
     return match;
   }
   o.$dartConstId = id;
   $consts[key] = o;
   return o;
 }
 
 function $Dart$MapLiteralFactory() {
   return native__CoreJsUtil__newMapLiteral();
 }