Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Unified Diff: runtime/vm/class_finalizer.h

Issue 9186058: Make the "sticky error" an Error instead of a String. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/allocation_test.cc ('k') | runtime/vm/class_finalizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/class_finalizer.h
===================================================================
--- runtime/vm/class_finalizer.h (revision 3366)
+++ runtime/vm/class_finalizer.h (working copy)
@@ -13,12 +13,12 @@
class AbstractType;
class AbstractTypeArguments;
class Class;
+class Error;
class Function;
class RawAbstractType;
class RawClass;
class RawType;
class Script;
-class String;
class Type;
class UnresolvedClass;
@@ -42,10 +42,10 @@
AbstractType* conflicting);
// Finalize and canonicalize type while parsing class cls.
- // Set the error message on failure (to String::null() if no error).
+ // Set the error message on failure (to Error::null() if no error).
static RawAbstractType* FinalizeAndCanonicalizeType(const Class& cls,
const AbstractType& type,
- String* errmsg);
+ Error* error);
// Pending classes are classes that need to be finalized.
static void AddPendingClasses(const GrowableArray<const Class*>& classes);
« no previous file with comments | « runtime/vm/allocation_test.cc ('k') | runtime/vm/class_finalizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698