Use hash map for event handler file descriptor map

runtime/bin/hashmap.h

+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+#ifndef BIN_HASHMAP_H_
+#define BIN_HASHMAP_H_
+
+#include "platform/globals.h"
+
+class HashMap {
+ public:
+  typedef bool (*MatchFun) (void* key1, void* key2);
+
+  static bool SamePointerValue(void* key1, void* key2) {
+    return key1 == key2;
+  }
+
+  // initial_capacity is the size of the initial hash map;
+  // it must be a power of 2 (and thus must not be 0).
+  HashMap(MatchFun match = &SamePointerValue, uint32_t initial_capacity = 8);

[Ivan Posva, 2012/01/20 21:42:57]

I am not sure I like the default parameters here. Please make the user specify
them.

[Søren Gjesse, 2012/01/23 09:03:49]

OK, removed defaults.

+
+  ~HashMap();
+
+  // HashMap entries are (key, value, hash) triplets.
+  // Some clients may not need to use the value slot
+  // (e.g. implementers of sets, where the key is the value).
+  struct Entry {
+    void* key;
+    void* value;
+    uint32_t hash;  // The full hash value for key.
+  };
+
+  // If an entry with matching key is found, Lookup()
+  // returns that entry. If no matching entry is found,
+  // but insert is set, a new entry is inserted with
+  // corresponding key, key hash, and NULL value.
+  // Otherwise, NULL is returned.
+  Entry* Lookup(void* key, uint32_t hash, bool insert);
+
+  // Removes the entry with matching key.
+  void Remove(void* key, uint32_t hash);
+
+  // Empties the hash map (occupancy() == 0).
+  void Clear();
+
+  // The number of (non-empty) entries in the table.
+  intptr_t occupancy() const { return occupancy_; }

[Ivan Posva, 2012/01/20 21:42:57]

Are occupancy and capacity really needed in the public API of HashMap?

[Søren Gjesse, 2012/01/23 09:03:49]

No, removed. It is used a a test, so I added a friend class for that.

+
+  // The capacity of the table. The implementation
+  // makes sure that occupancy is at most 80% of
+  // the table capacity.
+  intptr_t capacity() const { return capacity_; }
+
+  // Iteration
+  //
+  // for (Entry* p = map.Start(); p != NULL; p = map.Next(p)) {
+  //   ...
+  // }
+  //
+  // If entries are inserted during iteration, the effect of
+  // calling Next() is undefined.
+  Entry* Start() const;
+  Entry* Next(Entry* p) const;
+
+ private:
+  MatchFun match_;
+  Entry* map_;
+  uint32_t capacity_;
+  uint32_t occupancy_;
+
+  Entry* map_end() const { return map_ + capacity_; }
+  Entry* Probe(void* key, uint32_t hash);
+  void Initialize(uint32_t capacity);
+  void Resize();
+};
+
+#endif  // BIN_HASHMAP_H_