Issue 933: Fix for resolving type of Function in field.

Issue 933: Fix for resolving type of Function in field.
http://code.google.com/p/dart/issues/detail?id=933


R=zundel@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=3410

[zundel, 2012-01-11 21:34:58]

http://codereview.chromium.org/9186015/diff/1/compiler/javatests/com/google/d...
File compiler/javatests/com/google/dart/compiler/type/TypeTestCase.java (right):

http://codereview.chromium.org/9186015/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/type/TypeTestCase.java:100:
assertEquals(message, expectedTypeErrors, 0);
even before your change, the way this test works makes the assertEquals()
message very confusing.  Ideally, If there were 2 errors and we expected 3, we'd
like to see: 

expected <3> errors, actual <2>

but with this code we'll get:

expected <1> errors, actual <0>

To fix, we should track expected errors and encountered errors in separate
variables.

[zundel, 2012-01-18 18:07:45]

lgtm

[regis, 2012-02-23 19:42:09]

https://chromiumcodereview.appspot.com/9186015/diff/3003/tests/language/src/F...
File tests/language/src/FunctionFieldTest.dart (right):

https://chromiumcodereview.appspot.com/9186015/diff/3003/tests/language/src/F...
tests/language/src/FunctionFieldTest.dart:4: // VMOptions=--fatal-type-errors
--enable_type_checks
The VM does not support --fatal-type-errors.

[scheglov, 2012-02-24 14:46:52]

> tests/language/src/FunctionFieldTest.dart:4: // VMOptions=--fatal-type-errors
> --enable_type_checks
> The VM does not support --fatal-type-errors.

How can we know this?

out/Debug_ia32$ ./dart --help
dart [<vm-flags>] <dart-script-file> [<dart-options>]

[zundel, 2012-02-24 15:38:57]

https://chromiumcodereview.appspot.com/9186015/diff/3003/tests/language/src/F...
File tests/language/src/FunctionFieldTest.dart (right):

https://chromiumcodereview.appspot.com/9186015/diff/3003/tests/language/src/F...
tests/language/src/FunctionFieldTest.dart:4: // VMOptions=--fatal-type-errors
--enable_type_checks
On 2012/02/23 19:42:09, regis wrote:
> The VM does not support --fatal-type-errors.

VMOptions is kind of a misnomer in that they are just cmdline flags passed to
whatever tool is being invoked.  The tools should be set to ignore unrecognized
options.