Issue 9178021: When adjusting page's live bytes counter from the mutator adjust owners unswept free bytes counter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9178021: When adjusting page's live bytes counter from the mutator adjust owners unswept free bytes counter. (Closed)

Created:
8 years, 11 months ago by Vyacheslav Egorov (Chromium)

Modified:
8 years, 11 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

When adjusting page's live bytes counter from the mutator adjust owners unswept free bytes counter. R=mstarzinger@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10426

Patch Set 1 #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -28 lines)			Patch
M	src/builtins.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/incremental-marking.cc	View	7 chunks	+11 lines, -11 lines	0 comments	Download
M	src/incremental-marking-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mark-compact.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mark-compact.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/mark-compact-inl.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/objects.cc	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/spaces.h	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	src/spaces.cc	View	2 chunks	+12 lines, -1 line	2 comments	Download
M	src/spaces-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with the one comment addressed!) http://codereview.chromium.org/9178021/diff/1/src/spaces.cc File src/spaces.cc (right): http://codereview.chromium.org/9178021/diff/1/src/spaces.cc#newcode656 src/spaces.cc:656: if (!chunk->InNewSpace()) { ...

8 years, 11 months ago (2012-01-18 09:12:18 UTC) #2

Vyacheslav Egorov (Chromium)

8 years, 11 months ago (2012-01-18 09:22:49 UTC) #3

addressed, landed.

http://codereview.chromium.org/9178021/diff/1/src/spaces.cc
File src/spaces.cc (right):

http://codereview.chromium.org/9178021/diff/1/src/spaces.cc#newcode656
src/spaces.cc:656: if (!chunk->InNewSpace()) {
On 2012/01/18 09:12:18, Michael Starzinger wrote:
> We need an additional check here to make sure that the page was elected for
lazy
> sweeping and isn't just being incrementally marked.

Yeah, thanks for catching it. Somehow I lost this check along the road.

Expand Messages | Collapse Messages