Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 9178017: Allow call-known-global to be used for call-sites with mismatched number of arguments. (Closed)

Created:
8 years, 11 months ago by Vyacheslav Egorov (Chromium)
Modified:
8 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Allow call-known-global and call-constant-function to be used for call-sites with mismatched number of arguments. Adjust InvokeFunction to avoid generating dead code when number when arity mismatch is detected in compile time. R=fschneider@google.com Committed: https://code.google.com/p/v8/source/detail?r=10424

Patch Set 1 #

Total comments: 1

Patch Set 2 : Relax call-constant-function restrictions as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -166 lines) Patch
M src/arm/lithium-codegen-arm.cc View 4 chunks +31 lines, -23 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 7 chunks +41 lines, -29 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 5 chunks +9 lines, -5 lines 0 comments Download
M src/ast.cc View 1 3 chunks +2 lines, -13 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +36 lines, -25 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 5 chunks +36 lines, -25 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 4 chunks +36 lines, -25 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 5 chunks +34 lines, -21 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Chromium)
8 years, 11 months ago (2012-01-17 15:00:22 UTC) #1
fschneider
LGTM. https://chromiumcodereview.appspot.com/9178017/diff/1/src/ast.cc File src/ast.cc (right): https://chromiumcodereview.appspot.com/9178017/diff/1/src/ast.cc#newcode757 src/ast.cc:757: return CanCallWithoutIC(target_, arguments()->length()); Maybe the restriction can be ...
8 years, 11 months ago (2012-01-17 15:50:09 UTC) #2
fschneider
8 years, 11 months ago (2012-01-17 15:53:08 UTC) #3
Still LGTM.

Powered by Google App Engine
This is Rietveld 408576698