[ChromeOS] Add option to set controlling terminal when launching process.

base/process_util_posix.cc

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <dirent.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <signal.h>
 #include <stdlib.h>
 #include <sys/resource.h>
 #include <sys/time.h>
@@ skipping 13 matching lines @@
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/process_util.h"
 #include "base/stringprintf.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/third_party/dynamic_annotations/dynamic_annotations.h"
 #include "base/threading/platform_thread.h"
 #include "base/threading/thread_restrictions.h"
 
+#if defined(OS_CHROMEOS)
+#include <sys/ioctl.h>
+#endif
+
 #if defined(OS_FREEBSD)
 #include <sys/event.h>
 #include <sys/ucontext.h>
 #endif
 
 #if defined(OS_MACOSX)
 #include <crt_externs.h>
 #include <sys/event.h>
 #else
 extern char** environ;
@@ skipping 625 matching lines @@
     // any hidden calls to malloc.
     void *malloc_thunk =
         reinterpret_cast<void*>(reinterpret_cast<intptr_t>(malloc) & ~4095);
     mprotect(malloc_thunk, 4096, PROT_READ | PROT_WRITE | PROT_EXEC);
     memset(reinterpret_cast<void*>(malloc), 0xff, 8);
 #endif  // 0
 
     // DANGER: no calls to malloc are allowed from now on:
     // http://crbug.com/36678
 
+#if defined(OS_CHROMEOS)
+    if (options.ctrl_terminal_fd >=0) {

[Evan Martin, 2012/01/20 19:03:03]

space before 0

[tbarzic, 2012/01/20 20:42:05]

Done.

+      if (HANDLE_EINTR(setsid()) == -1 ||
+          HANDLE_EINTR(
+              ioctl(options.ctrl_terminal_fd, TIOCSCTTY, NULL)) == -1) {
+        RAW_LOG(WARNING, "Unable to set controlling terminal");

[Evan Martin, 2012/01/20 19:03:03]

I wonder if it'd be more useful to specify what failed here.  The log will only
be read by someone technical, so perhaps referencing setsid() or
ioctl(TIOCSCTTY) in the message would be helpful.  Your call.

[tbarzic, 2012/01/20 20:42:05]

Good suggestion...

+      }
+    }
+#endif  // defined(OS_CHROMEOS)
+
     if (options.fds_to_remap) {
       for (file_handle_mapping_vector::const_iterator
                it = options.fds_to_remap->begin();
            it != options.fds_to_remap->end(); ++it) {
         fd_shuffle1.push_back(InjectionArc(it->first, it->second, false));
         fd_shuffle2.push_back(InjectionArc(it->first, it->second, false));
       }
     }
 
 #if defined(OS_MACOSX)
@@ skipping 615 matching lines @@
   if (IsChildDead(process))
     return;
 
   BackgroundReaper* reaper = new BackgroundReaper(process, 0);
   PlatformThread::CreateNonJoinable(0, reaper);
 }
 
 #endif  // !defined(OS_MACOSX)
 
 }  // namespace base