Issue 9169076: Prepare push to trunk. Now working on version 3.9.0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9169076: Prepare push to trunk. Now working on version 3.9.0. (Closed)

Created:
8 years, 11 months ago by Yang

Modified:
8 years, 11 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Prepare push to trunk. Now working on version 3.9.0. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=10506

Patch Set 1 #

Total comments: 3

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -2 lines)			Patch
	M	ChangeLog	View		1 chunk	+19 lines, -0 lines	3 comments	Download
	M	src/version.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

8 years, 11 months ago (2012-01-26 07:31:45 UTC) #2

LGTM with nits

https://chromiumcodereview.appspot.com/9169076/diff/1/ChangeLog
File ChangeLog (right):

https://chromiumcodereview.appspot.com/9169076/diff/1/ChangeLog#newcode5
ChangeLog:5: Provide access to function inferred name in V8 public API.
Perhaps mention Yury Semikhatsky and "GetInferredName" explicitly

https://chromiumcodereview.appspot.com/9169076/diff/1/ChangeLog#newcode13
ChangeLog:13: Introduce readbinary function in d8 to read binary files.
s/readbinary/ReadBinary/

https://chromiumcodereview.appspot.com/9169076/diff/1/ChangeLog#newcode15
ChangeLog:15: Further robustify the keyed lookup cache against unlucky hash
seeds.
I would remove this, it is subsumed by the item below.

Expand Messages | Collapse Messages