chrome/browser/extensions/app_process_apitest.cc - Issue 9169065: Reloading page after installing app should bring it into correct process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/app_process_apitest.cc

Issue 9169065: Reloading page after installing app should bring it into correct process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressing initial code review comments. Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/app_process_apitest.cc

diff --git a/chrome/browser/extensions/app_process_apitest.cc b/chrome/browser/extensions/app_process_apitest.cc

index 39ff6dd69d692234f2ea17870f32f8188c83cc45..ab9a4f1a7474b27502c4a5ae4255c8a3a6787d0f 100644

--- a/chrome/browser/extensions/app_process_apitest.cc

+++ b/chrome/browser/extensions/app_process_apitest.cc

@@ -388,8 +388,7 @@ IN_PROC_BROWSER_TEST_F(AppApiTest, MAYBE_AppProcessRedirectBack) {

// Ensure that reloading a URL after installing or uninstalling it as an app

// correctly swaps the process. (http://crbug.com/80621)

-// Disabled until we get a correct fix for 80621. See http://crbug.com/102408.

-IN_PROC_BROWSER_TEST_F(AppApiTest, DISABLED_ReloadIntoAppProcess) {

+IN_PROC_BROWSER_TEST_F(AppApiTest, ReloadIntoAppProcess) {

CommandLine::ForCurrentProcess()->AppendSwitch(

switches::kDisablePopupBlocking);

« no previous file with comments | « no previous file | chrome/renderer/chrome_content_renderer_client.cc » ('j') | content/browser/tab_contents/navigation_controller_impl.cc » ('J')