Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: runtime/vm/allocation.cc

Issue 9169063: Add support for native ports in the vm. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/allocation.h" 5 #include "vm/allocation.h"
6 6
7 #include "platform/assert.h" 7 #include "platform/assert.h"
8 #include "vm/isolate.h" 8 #include "vm/isolate.h"
9 #include "vm/zone.h" 9 #include "vm/zone.h"
10 10
11 namespace dart { 11 namespace dart {
12 12
13 StackResource::StackResource(Isolate* isolate) : isolate_(isolate) { 13 StackResource::StackResource(Isolate* isolate)
14 previous_ = isolate->top_resource(); 14 : isolate_(isolate), previous_(NULL) {
15 isolate->set_top_resource(this); 15 // We can only have longjumps and exceptions when there is a current
16 // isolate. If there is no is no current isolate, we don't need to
siva 2012/02/01 00:38:56 "is no" twice?
turnidge 2012/02/01 18:51:27 Done.
17 // protect this case.
18 if (isolate) {
19 previous_ = isolate->top_resource();
20 isolate->set_top_resource(this);
21 }
16 } 22 }
17 23
18 24
19 StackResource::~StackResource() { 25 StackResource::~StackResource() {
20 StackResource* top = isolate()->top_resource(); 26 if (isolate()) {
21 ASSERT(top == this); 27 StackResource* top = isolate()->top_resource();
22 isolate()->set_top_resource(previous_); 28 ASSERT(top == this);
29 isolate()->set_top_resource(previous_);
30 } else {
31 // If there was no current isolate when we created the resource,
32 // there should be no current isolate when it is destroyed.
33 ASSERT(Isolate::Current() == NULL);
34 }
siva 2012/02/01 00:38:56 Could we have a generic assert ASSERT(Isolate::Cur
turnidge 2012/02/01 18:51:27 Good idea. Done.
23 } 35 }
24 36
25 ZoneAllocated::~ZoneAllocated() { 37 ZoneAllocated::~ZoneAllocated() {
26 UNREACHABLE(); 38 UNREACHABLE();
27 } 39 }
28 40
29 void* ZoneAllocated::operator new(uword size) { 41 void* ZoneAllocated::operator new(uword size) {
30 Isolate* isolate = Isolate::Current(); 42 Isolate* isolate = Isolate::Current();
31 ASSERT(isolate != NULL); 43 ASSERT(isolate != NULL);
32 ASSERT(isolate->current_zone() != NULL); 44 ASSERT(isolate->current_zone() != NULL);
33 return reinterpret_cast<void*>(isolate->current_zone()->Allocate(size)); 45 return reinterpret_cast<void*>(isolate->current_zone()->Allocate(size));
34 } 46 }
35 47
36 } // namespace dart 48 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698