Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1469)

Side by Side Diff: src/mark-compact.h

Issue 9169045: Refactoring only: Extracted 2 methods from ClearNonLiveTransitions (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Incorporated online and offline review suggestions Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/mark-compact.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 678 matching lines...) Expand 10 before | Expand all | Expand 10 after
689 // literal map caches removing unmarked entries. 689 // literal map caches removing unmarked entries.
690 void ProcessMapCaches(); 690 void ProcessMapCaches();
691 691
692 // Callback function for telling whether the object *p is an unmarked 692 // Callback function for telling whether the object *p is an unmarked
693 // heap object. 693 // heap object.
694 static bool IsUnmarkedHeapObject(Object** p); 694 static bool IsUnmarkedHeapObject(Object** p);
695 695
696 // Map transitions from a live map to a dead map must be killed. 696 // Map transitions from a live map to a dead map must be killed.
697 // We replace them with a null descriptor, with the same key. 697 // We replace them with a null descriptor, with the same key.
698 void ClearNonLiveTransitions(); 698 void ClearNonLiveTransitions();
699 void ClearNonLivePrototypeTransitions(Map* map);
700 void ClearNonLiveMapTransitions(Map* map, MarkBit map_mark);
699 701
700 // Marking detaches initial maps from SharedFunctionInfo objects 702 // Marking detaches initial maps from SharedFunctionInfo objects
701 // to make this reference weak. We need to reattach initial maps 703 // to make this reference weak. We need to reattach initial maps
702 // back after collection. This is either done during 704 // back after collection. This is either done during
703 // ClearNonLiveTransitions pass or by calling this function. 705 // ClearNonLiveTransitions pass or by calling this function.
704 void ReattachInitialMaps(); 706 void ReattachInitialMaps();
705 707
706 // Mark all values associated with reachable keys in weak maps encountered 708 // Mark all values associated with reachable keys in weak maps encountered
707 // so far. This might push new object or even new weak maps onto the 709 // so far. This might push new object or even new weak maps onto the
708 // marking stack. 710 // marking stack.
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
757 759
758 friend class Heap; 760 friend class Heap;
759 }; 761 };
760 762
761 763
762 const char* AllocationSpaceName(AllocationSpace space); 764 const char* AllocationSpaceName(AllocationSpace space);
763 765
764 } } // namespace v8::internal 766 } } // namespace v8::internal
765 767
766 #endif // V8_MARK_COMPACT_H_ 768 #endif // V8_MARK_COMPACT_H_
OLDNEW
« no previous file with comments | « no previous file | src/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698