Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Issue 9167034: Add support for Run + Quit to WebKit::WebThread (Closed)

Created:
8 years, 11 months ago by jamesr
Modified:
8 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Add support for Run, Quit, and RunAllPending to WebKit::WebThread BUG=none http://src.chromium.org/viewvc/chrome?view=rev&revision=118548

Patch Set 1 #

Patch Set 2 : add CHECK(IsCurrentThread()) to new functions to discourage bad cross-thread use #

Patch Set 3 : update with MessageLoop-agnostic API names #

Total comments: 1

Patch Set 4 : uses MessageLoop::current and restores MessageLoopProxy, removes OVERRIDE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -4 lines) Patch
M webkit/glue/webthread_impl.h View 1 2 3 2 chunks +10 lines, -4 lines 0 comments Download
M webkit/glue/webthread_impl.cc View 1 2 3 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jamesr
Patch for consideration. I had to change the main thread implementation from using a scoped_refptr<MessageLoopProxy> ...
8 years, 11 months ago (2012-01-11 01:28:56 UTC) #1
darin (slow to review)
https://chromiumcodereview.appspot.com/9167034/diff/8001/webkit/glue/webthread_impl.cc File webkit/glue/webthread_impl.cc (right): https://chromiumcodereview.appspot.com/9167034/diff/8001/webkit/glue/webthread_impl.cc#newcode115 webkit/glue/webthread_impl.cc:115: message_loop_->Run(); you could also just use MessageLoop::current()->Run() assuming you ...
8 years, 11 months ago (2012-01-19 17:57:36 UTC) #2
jamesr
That's much cleaner! PTAL.
8 years, 11 months ago (2012-01-19 19:22:35 UTC) #3
darin (slow to review)
LGTM
8 years, 11 months ago (2012-01-19 21:54:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/9167034/13001
8 years, 11 months ago (2012-01-19 21:57:28 UTC) #5
commit-bot: I haz the power
Try job failure for 9167034-13001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 11 months ago (2012-01-19 23:49:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/9167034/13001
8 years, 11 months ago (2012-01-20 00:22:42 UTC) #7
commit-bot: I haz the power
8 years, 11 months ago (2012-01-20 03:08:16 UTC) #8
Try job failure for 9167034-13001 (retry) (retry) on mac_rel for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698