chrome/browser/content_settings/content_settings_mock_observer.h - Issue 9159053: Coverity: pass ContentSettingsPattern by const ref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/content_settings_mock_observer.h

Issue 9159053: Coverity: pass ContentSettingsPattern by const ref (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix MockObserver Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/content_settings/content_settings_mock_observer.h

diff --git a/chrome/browser/content_settings/content_settings_mock_observer.h b/chrome/browser/content_settings/content_settings_mock_observer.h

index 0c8660411dcc80daa5878f1a6ba2cd008ad7e236..c9a80765452ee623f1ad5f5360a147e7d768ddf5 100644

--- a/chrome/browser/content_settings/content_settings_mock_observer.h

+++ b/chrome/browser/content_settings/content_settings_mock_observer.h

@@ -18,8 +18,8 @@ class MockObserver : public Observer {

virtual ~MockObserver();

MOCK_METHOD4(OnContentSettingChanged,

- void(ContentSettingsPattern primary_pattern,

- ContentSettingsPattern secondary_pattern,

+ void(const ContentSettingsPattern& primary_pattern,

+ const ContentSettingsPattern& secondary_pattern,

ContentSettingsType content_type,

std::string resource_identifier));

private:

« no previous file with comments | « no previous file | chrome/browser/content_settings/content_settings_observable_provider.h » ('j') | no next file with comments »