Issue 9159050: Don't run cygwin setup on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9159050: Don't run cygwin setup on Mac (Closed)

Created:
8 years, 10 months ago by scottmg

Modified:
8 years, 10 months ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Was previously testing wrong condition: 'win' in platform is true for "dar'win'" too. BUG=111731 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119766

Patch Set 2 : don't run on dar'win' #

Total comments: 2

Patch Set 3 : cleaner test for windows #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	build/win/setup_cygwin_mount.py	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

https://chromiumcodereview.appspot.com/9159050/diff/3001/build/win/setup_cygwin_mount.py File build/win/setup_cygwin_mount.py (left): https://chromiumcodereview.appspot.com/9159050/diff/3001/build/win/setup_cygwin_mount.py#oldcode11 build/win/setup_cygwin_mount.py:11: if 'win' in sys.platform: if sys.platform in ('win32', 'cygwin'): ...

8 years, 10 months ago (2012-01-30 23:29:06 UTC) #2

scottmg

8 years, 10 months ago (2012-01-30 23:30:38 UTC) #4

https://chromiumcodereview.appspot.com/9159050/diff/3001/build/win/setup_cygw...
File build/win/setup_cygwin_mount.py (left):

https://chromiumcodereview.appspot.com/9159050/diff/3001/build/win/setup_cygw...
build/win/setup_cygwin_mount.py:11: if 'win' in sys.platform:
On 2012/01/30 23:29:06, Ryan Sleevi wrote:
> if sys.platform in ('win32', 'cygwin'): ?
> 
> matches depot_tools/gcl.py

Done.