Issue 9159048: Fix compile with Aura/Mac ash_shell and workspace controller

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9159048: Fix compile with Aura/Mac ash_shell and workspace controller (Closed)

Created:
8 years, 10 months ago by dhollowa

Modified:
8 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix compile with Aura/Mac ash_shell and workspace controller Fixes link issues on Mac/AuraShell.app with WorkspaceController. implemented. BUG=None TEST=Compile on Mac/Aura. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119941

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -10 lines)			Patch
M	ash/wm/workspace_controller.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/wm/workspace_controller.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	ui/aura/root_window.cc	View	1	4 chunks	+12 lines, -8 lines	0 comments	Download
M	ui/aura/window.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

dhollowa

Hey Scott, I had to add changes to window.cc and root_window.cc regarding reverse iterators. Apparently ...

8 years, 10 months ago (2012-01-31 16:40:04 UTC) #3

LGTM