Disable sync promo for Chromium builds

Disable sync promo for Chromium builds

BUG=111985
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120009

[Elliot Glaysher, 2012-01-30 23:01:19]

Thank you for implementing this. The GOOGLE_CHROME_BUILD is the define you're
looking for (see common.gypi).

lgtm, but I have no actual experience here.

[Dan Beam, 2012-01-30 23:16:40]

https://chromiumcodereview.appspot.com/9159047/diff/2001/chrome/browser/ui/we...
File chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc (right):

https://chromiumcodereview.appspot.com/9159047/diff/2001/chrome/browser/ui/we...
chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc:141: #if
defined(OS_CHROMEOS)
Why not here?

#if defined(OS_CHROMEOS) || !defined(GOOGLE_CHROME_BUILD)

[sail, 2012-01-30 23:24:21]

https://chromiumcodereview.appspot.com/9159047/diff/2001/chrome/browser/ui/we...
File chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc (right):

https://chromiumcodereview.appspot.com/9159047/diff/2001/chrome/browser/ui/we...
chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc:141: #if
defined(OS_CHROMEOS)
On 2012/01/30 23:16:40, Dan Beam wrote:
> Why not here?
> 
> #if defined(OS_CHROMEOS) || !defined(GOOGLE_CHROME_BUILD)

Doing it lower allows us to enable it using a command line flag. This is useful
for testing.

[Dan Beam, 2012-01-30 23:36:28]

yeah, I see what you mean, I don't feel like building the official build just to
see chrome://syncpromo, lgtm

[sail, 2012-01-31 23:02:55]

jhawkins: ping!

[James Hawkins, 2012-01-31 23:03:53]

lgtm

[commit-bot: I haz the power, 2012-01-31 23:05:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/9159047/5001

[commit-bot: I haz the power, 2012-02-01 02:06:47]

Change committed as 120009