Fix handling of 'c: if (0) break c; else ()' where a parser optimization

Fix handling of 'c: if (0) break c; else ()' where a parser optimization
leaves a trailing ";" after removing the break.

Committed: https://code.google.com/p/v8/source/detail?r=10628

[Lasse Reichstein Nielsen, 2012-02-02 10:05:18]

Consider adding a test for this.

https://chromiumcodereview.appspot.com/9159043/diff/1/src/parser.cc
File src/parser.cc (right):

https://chromiumcodereview.appspot.com/9159043/diff/1/src/parser.cc#newcode2134
src/parser.cc:2134: }
The semicolon *must* be there (or be inserted by automatic semicolon insertion),
so use 
  ExpectSemicolon(CHECK_OK);
like below.
Otherwise it'll still match something like
  foo: break foo var x = 10;

[Kevin Jones, 2012-02-03 18:44:18]

On 2012/02/02 10:05:18, Lasse Reichstein Nielsen wrote:
> Consider adding a test for this.
> 
> https://chromiumcodereview.appspot.com/9159043/diff/1/src/parser.cc
> File src/parser.cc (right):
> 
>
https://chromiumcodereview.appspot.com/9159043/diff/1/src/parser.cc#newcode2134
> src/parser.cc:2134: }
> The semicolon *must* be there (or be inserted by automatic semicolon
insertion),
> so use 
>   ExpectSemicolon(CHECK_OK);
> like below.
> Otherwise it'll still match something like
>   foo: break foo var x = 10;

Corrected and test case included.

[Lasse Reichstein Nielsen, 2012-02-03 20:11:13]

LGTM. Very good. I'll land it Monday, or possibly Tuesday.

https://chromiumcodereview.appspot.com/9159043/diff/4001/test/mjsunit/regress...
File test/mjsunit/regress/regress-1924.js (right):

https://chromiumcodereview.appspot.com/9159043/diff/4001/test/mjsunit/regress...
test/mjsunit/regress/regress-1924.js:33: assertThrows("a: break a
a",SyntaxError)
Space after comma (just for readability)

https://chromiumcodereview.appspot.com/9159043/diff/4001/test/mjsunit/regress...
test/mjsunit/regress/regress-1924.js:36: assertThrows("a: break a
var",SyntaxError)
Put a variable name after "var", otherwise it would be a syntax error anyway.

https://chromiumcodereview.appspot.com/9159043/diff/4001/test/mjsunit/regress...
test/mjsunit/regress/regress-1924.js:41: c: if (0) break c; else {}
You could also test the else branch (it also inherits the label).