Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 9159005: Move operator<< for StringPiece into string_piece.{h,cc} (Closed)

Created:
8 years, 11 months ago by akalin
Modified:
8 years, 11 months ago
CC:
chromium-reviews, jshin+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Move operator<< for StringPiece into string_piece.{h,cc} BUG=110651 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118416

Patch Set 1 #

Patch Set 2 : Fix compile error #

Patch Set 3 : Fix another compile error #

Patch Set 4 : Fix license #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -27 lines) Patch
M base/logging.h View 1 2 3 2 chunks +1 line, -11 lines 0 comments Download
M base/logging.cc View 1 chunk +3 lines, -12 lines 0 comments Download
M base/string_piece.h View 1 2 3 3 chunks +5 lines, -1 line 0 comments Download
M base/string_piece.cc View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download
M chrome/renderer/extensions/chrome_v8_extension.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M net/dns/dns_transaction.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
akalin
+suzhe for review, +evan for OWNERS
8 years, 11 months ago (2012-01-19 07:22:37 UTC) #1
James Su
Thanks for help on it. LGTM. On 2012/01/19 07:22:37, akalin wrote: > +suzhe for review, ...
8 years, 11 months ago (2012-01-19 07:31:38 UTC) #2
akalin
Fix compile error in net. -evan, +willchan for base and net OWNERS
8 years, 11 months ago (2012-01-19 08:41:55 UTC) #3
akalin
forgot willchan was away. +eroman for net OWNERS, +evan for base OWNERS.
8 years, 11 months ago (2012-01-19 18:13:18 UTC) #4
eroman
LGTM for net/*
8 years, 11 months ago (2012-01-19 19:36:33 UTC) #5
Evan Martin
LGTM
8 years, 11 months ago (2012-01-19 19:46:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/9159005/7003
8 years, 11 months ago (2012-01-19 19:49:20 UTC) #7
commit-bot: I haz the power
Try job failure for 9159005-7003 (retry) on linux_rel for step "ui_tests". It's a second try, ...
8 years, 11 months ago (2012-01-19 21:14:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/9159005/7003
8 years, 11 months ago (2012-01-19 21:16:25 UTC) #9
commit-bot: I haz the power
Try job failure for 9159005-7003 (retry) (retry) on mac_rel for step "browser_tests". It's a second ...
8 years, 11 months ago (2012-01-19 23:59:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/9159005/2014
8 years, 11 months ago (2012-01-20 01:45:47 UTC) #11
commit-bot: I haz the power
8 years, 11 months ago (2012-01-20 03:47:22 UTC) #12
Try job failure for 9159005-2014 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698