Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: src/ic.cc

Issue 9150032: Revert "Immediately use the generic stub when storing into COW arrays" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1659 matching lines...) Expand 10 before | Expand all | Expand 10 after
1670 1670
1671 if (use_ic) { 1671 if (use_ic) {
1672 Handle<Code> stub = (strict_mode == kStrictMode) 1672 Handle<Code> stub = (strict_mode == kStrictMode)
1673 ? generic_stub_strict() 1673 ? generic_stub_strict()
1674 : generic_stub(); 1674 : generic_stub();
1675 if (object->IsJSObject()) { 1675 if (object->IsJSObject()) {
1676 Handle<JSObject> receiver = Handle<JSObject>::cast(object); 1676 Handle<JSObject> receiver = Handle<JSObject>::cast(object);
1677 if (receiver->elements()->map() == 1677 if (receiver->elements()->map() ==
1678 isolate()->heap()->non_strict_arguments_elements_map()) { 1678 isolate()->heap()->non_strict_arguments_elements_map()) {
1679 stub = non_strict_arguments_stub(); 1679 stub = non_strict_arguments_stub();
1680 } else if (receiver->elements()->map() ==
1681 isolate()->heap()->fixed_cow_array_map()) {
1682 // Do nothing, just keep the generic stub.
1683 } else if (!force_generic) { 1680 } else if (!force_generic) {
1684 if (key->IsSmi() && (target() != *non_strict_arguments_stub())) { 1681 if (key->IsSmi() && (target() != *non_strict_arguments_stub())) {
1685 StubKind stub_kind = STORE_NO_TRANSITION; 1682 StubKind stub_kind = STORE_NO_TRANSITION;
1686 if (receiver->GetElementsKind() == FAST_SMI_ONLY_ELEMENTS) { 1683 if (receiver->GetElementsKind() == FAST_SMI_ONLY_ELEMENTS) {
1687 if (value->IsHeapNumber()) { 1684 if (value->IsHeapNumber()) {
1688 stub_kind = STORE_TRANSITION_SMI_TO_DOUBLE; 1685 stub_kind = STORE_TRANSITION_SMI_TO_DOUBLE;
1689 } else if (value->IsHeapObject()) { 1686 } else if (value->IsHeapObject()) {
1690 stub_kind = STORE_TRANSITION_SMI_TO_OBJECT; 1687 stub_kind = STORE_TRANSITION_SMI_TO_OBJECT;
1691 } 1688 }
1692 } else if (receiver->GetElementsKind() == FAST_DOUBLE_ELEMENTS) { 1689 } else if (receiver->GetElementsKind() == FAST_DOUBLE_ELEMENTS) {
(...skipping 735 matching lines...) Expand 10 before | Expand all | Expand 10 after
2428 #undef ADDR 2425 #undef ADDR
2429 }; 2426 };
2430 2427
2431 2428
2432 Address IC::AddressFromUtilityId(IC::UtilityId id) { 2429 Address IC::AddressFromUtilityId(IC::UtilityId id) {
2433 return IC_utilities[id]; 2430 return IC_utilities[id];
2434 } 2431 }
2435 2432
2436 2433
2437 } } // namespace v8::internal 2434 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698