Initialize IPC:ChannelHandle from existing HANDLE

ipc/ipc_channel_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ipc/ipc_channel_win.h"
 
 #include <windows.h>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
@@ skipping 96 matching lines @@
 // static
 const std::wstring Channel::ChannelImpl::PipeName(
     const std::string& channel_id) {
   std::string name("\\\\.\\pipe\\chrome.");
   return ASCIIToWide(name.append(channel_id));
 }
 
 bool Channel::ChannelImpl::CreatePipe(const IPC::ChannelHandle &channel_handle,
                                       Mode mode) {
   DCHECK_EQ(INVALID_HANDLE_VALUE, pipe_);
   const std::wstring pipe_name = PipeName(channel_handle.name);

[cpu_(ooo_6.6-7.5), 2012/01/19 20:56:05]

pipe_name needs to move down. Another idea is to check that !name.empty() and
pipe.IsValid() cannot be true at the same time.

-  if (mode & MODE_SERVER_FLAG) {
+  // If we already have a valid pipe for channel just copy it.
+  if (channel_handle.pipe.IsValid()) {
+    DuplicateHandle(GetCurrentProcess(),

[cpu_(ooo_6.6-7.5), 2012/01/19 20:56:05]

On duplicate failure pipe_ what value does it contain?

Seems prudent to return false here. Or see my comment in the scopedhandle file.

+                    channel_handle.pipe,
+                    GetCurrentProcess(),
+                    &pipe_,
+                    0,
+                    FALSE,
+                    DUPLICATE_SAME_ACCESS);
+  } else if (mode & MODE_SERVER_FLAG) {
     pipe_ = CreateNamedPipeW(pipe_name.c_str(),
-                             PIPE_ACCESS_DUPLEX | FILE_FLAG_OVERLAPPED |
+                              PIPE_ACCESS_DUPLEX | FILE_FLAG_OVERLAPPED |

[cpu_(ooo_6.6-7.5), 2012/01/19 20:56:05]

indentation seems weird

                               FILE_FLAG_FIRST_PIPE_INSTANCE,
-                             PIPE_TYPE_BYTE | PIPE_READMODE_BYTE,
-                             1,
-                             Channel::kReadBufferSize,
-                             Channel::kReadBufferSize,
-                             5000,
-                             NULL);
+                              PIPE_TYPE_BYTE | PIPE_READMODE_BYTE,
+                              1,
+                              Channel::kReadBufferSize,
+                              Channel::kReadBufferSize,
+                              5000,
+                              NULL);
   } else if (mode & MODE_CLIENT_FLAG) {
     pipe_ = CreateFileW(pipe_name.c_str(),
                         GENERIC_READ | GENERIC_WRITE,
                         0,
                         NULL,
                         OPEN_EXISTING,
                         SECURITY_SQOS_PRESENT | SECURITY_IDENTIFICATION |
                             FILE_FLAG_OVERLAPPED,
                         NULL);
   } else {
     NOTREACHED();
   }
+
   if (pipe_ == INVALID_HANDLE_VALUE) {
     // If this process is being closed, the pipe may be gone already.
     LOG(WARNING) << "Unable to create pipe \"" << pipe_name <<
                     "\" in " << (mode == 0 ? "server" : "client")
                     << " mode. Error :" << GetLastError();
     return false;
   }
 
   // Create the Hello message to be sent when Connect is called
   scoped_ptr<Message> m(new Message(MSG_ROUTING_NONE,
@@ skipping 274 matching lines @@
 bool Channel::Send(Message* message) {
   return channel_impl_->Send(message);
 }
 
 // static
 bool Channel::IsNamedServerInitialized(const std::string& channel_id) {
   return ChannelImpl::IsNamedServerInitialized(channel_id);
 }
 
 }  // namespace IPC