Issue 9150026: MIPS: Allow call-known-global and call-constant-function to be used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9150026: MIPS: Allow call-known-global and call-constant-function to be used (Closed)

Created:
8 years, 11 months ago by kalmard

Modified:
8 years, 11 months ago

Reviewers:
kisg, Paul Lind, Vyacheslav Egorov (Chromium), danno

CC:
v8-dev

Visibility:
Public.

More Reviews

Description

MIPS: Allow call-known-global and call-constant-function to be used for call-sites with mismatched number of arguments. Port r10424 (92a05c9c). Original commit message: Adjust InvokeFunction to avoid generating dead code when number when arity mismatch is detected in compile time. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10456

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -53 lines)			Patch
M	src/mips/lithium-codegen-mips.cc	View	4 chunks	+31 lines, -23 lines	0 comments	Download
M	src/mips/macro-assembler-mips.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	7 chunks	+39 lines, -25 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	5 chunks	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kalmard

Successful testing of v8 on MIPS requires the following patches to be landed as well: ...

8 years, 11 months ago (2012-01-19 12:42:26 UTC) #1

lgtm, I am going to land.

Expand Messages | Collapse Messages