Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3838)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

Issue 914813002: [App banners] Start addressing race conditions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revamping Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
index 44b4d407d0078d3861d0d7117430aead530a3d81..8024fc8cd732fe45c756bcea566d0ed969dd5aa7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
@@ -146,10 +146,10 @@ public class AppBannerManager extends EmptyTabObserver {
nativeSetTimeDeltaForTesting(days);
}
- /** Records how many native BitmapFetchers are actively retrieving app icons. */
+ /** Returns whether a BitmapFetcher is actively retrieving an app icon. */
@VisibleForTesting
- public int getNumActiveFetchersForTesting() {
- return nativeGetNumActiveFetchers(mNativePointer);
+ public boolean isFetcherActiveForTesting() {
+ return nativeIsFetcherActive(mNativePointer);
}
private static native boolean nativeIsEnabled();
@@ -162,7 +162,7 @@ public class AppBannerManager extends EmptyTabObserver {
// Testing methods.
private static native void nativeSetTimeDeltaForTesting(int days);
- private native int nativeGetNumActiveFetchers(long nativeAppBannerManager);
+ private native boolean nativeIsFetcherActive(long nativeAppBannerManager);
// UMA tracking.
private static native void nativeRecordDismissEvent(int metric);

Powered by Google App Engine
This is Rietveld 408576698