Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationWithPrefixTest.java

Issue 9148026: Recompile unit with potential conflict/dependency on some top-level symbol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix for compiling corelib, so NPE in TreeShaker Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationWithPrefixTest.java
diff --git a/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationWithPrefixTest.java b/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationWithPrefixTest.java
index 41148f62be7dd247d4fb77d2af6bd210a30d1122..680108d410d6095e20ac96276d827dc9aa7897e8 100644
--- a/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationWithPrefixTest.java
+++ b/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationWithPrefixTest.java
@@ -4,7 +4,6 @@
package com.google.dart.compiler.end2end.inc;
-import static com.google.dart.compiler.DartCompiler.EXTENSION_API;
import static com.google.dart.compiler.DartCompiler.EXTENSION_DEPS;
import static com.google.dart.compiler.backend.js.AbstractJsBackend.EXTENSION_APP_JS;
import static com.google.dart.compiler.backend.js.AbstractJsBackend.EXTENSION_JS;
@@ -98,12 +97,11 @@ public class IncrementalCompilationWithPrefixTest extends CompilerTestCase {
someLibSource.remapSource("some.prefixable.lib.dart", "some.prefixable.modified.lib.dart");
compile();
- didWrite("my.unprefixed.app.dart", EXTENSION_JS, provider);
- didWrite("my.unprefixed.app.dart", EXTENSION_APP_JS, provider);
- didWrite("my.unprefixed.app.dart", EXTENSION_DEPS, provider);
- didWrite("some.prefixable.lib.dart", EXTENSION_JS, provider);
- didWrite("some.prefixable.lib.dart", EXTENSION_DEPS, provider);
- didWrite("some.prefixable.lib.dart", EXTENSION_API, provider);
+ didWrite("my.unprefixed.app.dart", EXTENSION_JS);
+ didWrite("my.unprefixed.app.dart", EXTENSION_APP_JS);
+ didWrite("my.unprefixed.app.dart", EXTENSION_DEPS);
+ didWrite("some.prefixable.lib.dart", EXTENSION_JS);
+ didWrite("some.prefixable.lib.dart", EXTENSION_DEPS);
}
public void testModifyPrefixedLib() {
@@ -122,12 +120,11 @@ public class IncrementalCompilationWithPrefixTest extends CompilerTestCase {
someLibSource.remapSource("some.prefixable.lib.dart", "some.prefixable.modified.lib.dart");
compile();
- didWrite("my.prefixed.app.dart", EXTENSION_JS, provider);
- didWrite("my.prefixed.app.dart", EXTENSION_APP_JS, provider);
- didWrite("my.prefixed.app.dart", EXTENSION_DEPS, provider);
- didWrite("some.prefixable.lib.dart", EXTENSION_JS, provider);
- didWrite("some.prefixable.lib.dart", EXTENSION_DEPS, provider);
- didWrite("some.prefixable.lib.dart", EXTENSION_API, provider);
+ didWrite("my.prefixed.app.dart", EXTENSION_JS);
+ didWrite("my.prefixed.app.dart", EXTENSION_APP_JS);
+ didWrite("my.prefixed.app.dart", EXTENSION_DEPS);
+ didWrite("some.prefixable.lib.dart", EXTENSION_JS);
+ didWrite("some.prefixable.lib.dart", EXTENSION_DEPS);
}
private void compile() {
@@ -147,13 +144,8 @@ public class IncrementalCompilationWithPrefixTest extends CompilerTestCase {
}
}
- private void didWrite(String sourceName, String extension, IncMockArtifactProvider provider) {
+ private void didWrite(String sourceName, String extension) {
String spec = sourceName + "/" + extension;
assertTrue("Expected write: " + spec, provider.writes.contains(spec));
}
-
- private void didNotWrite(String sourceName, String extension, IncMockArtifactProvider provider) {
- String spec = sourceName + "/" + extension;
- assertFalse("Didn't expect write: " + spec, provider.writes.contains(spec));
- }
}

Powered by Google App Engine
This is Rietveld 408576698