Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: compiler/java/com/google/dart/compiler/ast/DartNode.java

Issue 9148026: Recompile unit with potential conflict/dependency on some top-level symbol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix for compiling corelib, so NPE in TreeShaker Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/ast/DartNode.java
diff --git a/compiler/java/com/google/dart/compiler/ast/DartNode.java b/compiler/java/com/google/dart/compiler/ast/DartNode.java
index 67cd158ace334418167ca46ef7f51c67904ae522..8c30143c89b5c764112d110e66c2bee22df8d2f6 100644
--- a/compiler/java/com/google/dart/compiler/ast/DartNode.java
+++ b/compiler/java/com/google/dart/compiler/ast/DartNode.java
@@ -143,24 +143,6 @@ public abstract class DartNode extends AbstractNode implements DartVisitable {
public abstract <R> R accept(DartPlainVisitor<R> visitor);
- public int computeHash() {
- // TODO(jgw): Remove this altogether in fixing b/5324113.
- //
- // This computes a "hash" of the class' interface by simply serializing it to diet source and
- // computing a hash of the string. This will work for now, but encodes too much information in
- // the hash, and is slower than it should be. It should also cache the result and invalidate it
- // if anything substantive changes.
- //
- // Examples of changes incorrectly captured by this hash, which would cause unnecessary
- // recompiled include:
- // - any change in method/field order would trigger an unnecessary recompile.
- // - purely lexical changes such as {int x; int y;} => {int x, y;}
- //
- DefaultTextOutput out = new DefaultTextOutput(false);
- new DartToSourceVisitor(out, true).accept(this);
- return out.toString().trim().hashCode();
- }
-
@Override
public DartNode clone() {
// TODO (fabiomfv) - Implement proper cloning when strictly needed.

Powered by Google App Engine
This is Rietveld 408576698