Issue 9146039: Provide access to function inferred name in v8 public API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9146039: Provide access to function inferred name in v8 public API (Closed)

Created:
8 years, 11 months ago by yurys

Modified:
8 years, 11 months ago

Reviewers:
mnaganov (inactive), danno

CC:
v8-dev, pfeldman, loislo

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Provide access to function inferred name in v8 public API Committed: https://code.google.com/p/v8/source/detail?r=10499

Patch Set 3 : '' #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
M	include/v8.h	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/api.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danno

LGTM with small nits http://codereview.chromium.org/9146039/diff/3002/include/v8.h File include/v8.h (right): http://codereview.chromium.org/9146039/diff/3002/include/v8.h#newcode1737 include/v8.h:1737: * in OO style, where ...

8 years, 11 months ago (2012-01-25 12:34:09 UTC) #2

yurys

8 years, 11 months ago (2012-01-25 12:43:57 UTC) #3

http://codereview.chromium.org/9146039/diff/3002/include/v8.h
File include/v8.h (right):

http://codereview.chromium.org/9146039/diff/3002/include/v8.h#newcode1737
include/v8.h:1737: * in OO style, where almost all functions are anonymous but
are assigned
On 2012/01/25 12:34:10, danno wrote:
> nit: s/in OO/in an OO/
> nit: s/almost all/many

Done.

Expand Messages | Collapse Messages

Issue 9146039: Provide access to function inferred name in v8 public API (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages