Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 9146038: Converting the email_this_page sample extension to manifest_version 2 (Closed)

Created:
8 years, 11 months ago by Mike West
Modified:
8 years, 11 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Converting the email_this_page sample extension to manifest_version 2 Resisting the desire to rewrite the whole thing. Ugh. BUG=111049 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119061

Patch Set 1 #

Patch Set 2 : Zipped. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -40 lines) Patch
M chrome/common/extensions/docs/examples/extensions/email_this_page.zip View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/email_this_page/manifest.json View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/email_this_page/options.html View 3 chunks +11 lines, -37 lines 0 comments Download
A chrome/common/extensions/docs/examples/extensions/email_this_page/options.js View 1 chunk +37 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/samples.html View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mike West
Another.
8 years, 11 months ago (2012-01-24 15:29:05 UTC) #1
abarth-chromium
8 years, 11 months ago (2012-01-24 16:45:08 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698