Issue 9146030: Revert 118790 - Compile error due to missing operator== on SkRegion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9146030: Revert 118790 - Compile error due to missing operator== on SkRegion (Closed)

Created:
8 years, 11 months ago by Ryan Sleevi

Modified:
8 years, 11 months ago

Reviewers:
Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 118790 - Compile error due to missing operator== on SkRegion Replace RectVectors with SkRegions in Decoder. BUG=105401 Review URL: http://codereview.chromium.org/9277001 TBR=wez@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118793

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+142 lines, -130 lines)			Patch
M	remoting/base/codec_test.cc	View	8 chunks	+39 lines, -35 lines	0 comments	Download
M	remoting/base/decoder.h	View	3 chunks	+15 lines, -9 lines	0 comments	Download
M	remoting/base/decoder_row_based.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	remoting/base/decoder_row_based.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	remoting/base/decoder_vp8.h	View	4 chunks	+13 lines, -12 lines	0 comments	Download
M	remoting/base/decoder_vp8.cc	View	8 chunks	+29 lines, -28 lines	0 comments	Download
M	remoting/client/frame_consumer.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	remoting/client/frame_consumer_proxy.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/client/frame_consumer_proxy.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	remoting/client/plugin/pepper_view.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	remoting/client/plugin/pepper_view.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	remoting/client/rectangle_update_decoder.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	remoting/client/rectangle_update_decoder.cc	View	4 chunks	+15 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

8 years, 11 months ago (2012-01-24 03:24:11 UTC) #2

(Also choked on Win)

http://build.chromium.org/p/chromium/builders/Linux%20Builder%20%28dbg%29%28s...

/usr/bin/ld: out/Debug/obj.target/remoting_unittests/remoting/base/codec_test.o:
in function testing::AssertionResult testing::internal::CmpHelperEQ<SkRegion,
SkRegion>(char const*, char const*, SkRegion const&, SkRegion
const&):testing/gtest/include/gtest/gtest.h:1316:error: undefined reference to
'operator==(SkRegion const&, SkRegion const&)'
collect2: ld returned 1 exit status
make: *** [out/Debug/remoting_unittests] Error 1

Expand Messages | Collapse Messages