client/tests/client/samples/total/total_test_lib.dart - Issue 9145004: Revert "Example showing alternate async measurement solution"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/tests/client/samples/total/total_test_lib.dart

Issue 9145004: Revert "Example showing alternate async measurement solution" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: client/tests/client/samples/total/total_test_lib.dart

diff --git a/client/tests/client/samples/total/total_test_lib.dart b/client/tests/client/samples/total/total_test_lib.dart

index 835410f8955e044c996304db657972a7b458bda5..826f36a0575a378dc063a43a2049f778a54119cb 100644

--- a/client/tests/client/samples/total/total_test_lib.dart

+++ b/client/tests/client/samples/total/total_test_lib.dart

@@ -57,8 +57,8 @@ totalTests() {

body.nodes.add(div);

HtmlUtils.setIntegerProperty(div, "left", 100, "px");

- window.requestMeasurementFrame(() {

- String valueAsString = div.computedStyle.left;

+ div.computedStyle.then((CSSStyleDeclaration computedStyle) {

+ String valueAsString = computedStyle.getPropertyValue("left");

// FIXME: Test fails, with valueAsString == "auto". However,

// setIntegerProperty works when tested in practice, so there is

// something wrong with recovering the value.

« no previous file with comments | « client/tests/client/samples/swarm/swarm_tests.dart ('k') | client/touch/Scroller.dart » ('j') | no next file with comments »