Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: chrome/browser/ssl/

Issue 914253004: Fix captive portal histogram in SSL interstitials. (Closed) Base URL:
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/
diff --git a/chrome/browser/ssl/ b/chrome/browser/ssl/
index 214c035317d472aeb545d1b119b16fe900a7a83a..8caf34b669594b4efc32d78cf883ed28a92eb04f 100644
--- a/chrome/browser/ssl/
+++ b/chrome/browser/ssl/
@@ -247,9 +247,6 @@ SSLBlockingPage::SSLBlockingPage(content::WebContents* web_contents,
- ssl_error_classification_->RecordCaptivePortalUMAStatistics(overridable_);
// Creating an interstitial without showing (e.g. from chrome://interstitials)
// it leaks memory, so don't create it here.
@@ -264,6 +261,11 @@ const void* SSLBlockingPage::GetTypeForTesting() const {
SSLBlockingPage::~SSLBlockingPage() {
+ // Captive portal detection results can arrive anytime during the interstitial
+ // is being displayed, so record it when the interstitial is going away.
+ ssl_error_classification_->RecordCaptivePortalUMAStatistics(overridable_);
if (!callback_.is_null()) {
// The page is closed without the user having chosen what to do, default to
// deny.
« no previous file with comments | « no previous file | chrome/browser/ssl/ » ('j') | chrome/browser/ssl/ » ('J')

Powered by Google App Engine
This is Rietveld 408576698