Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 914253004: Fix captive portal histogram in SSL interstitials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 2309a4abe4dc9104531674aa4cc9692facfb7595..3bb41b5473447a761eaaadc9635dd1047161f034 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -57399,39 +57399,40 @@ To add a new entry, add it with any value and run test to compute valid value.
</enum>
<enum name="SSLCaptivePortal" type="int">
- <int value="0"
+ <int value="0" label="All captive portal events (CAPTIVE_PORTAL_ALL)"/>
+ <int value="1"
label="Chrome captive portal detection enabled
(CAPTIVE_PORTAL_DETECTION_ENABLED)"/>
- <int value="1"
+ <int value="2"
label="Chrome captive portal detection enabled on an overridable SSL
error page (CAPTIVE_PORTAL_DETECTION_ENABLED_OVERRIDABLE)">
- This is a subset of CAPTIVE_PORTAL_DETECTION_ENABLED (bucket 0), the only
+ This is a subset of CAPTIVE_PORTAL_DETECTION_ENABLED (bucket 1), the only
difference is that it is for overridable errors.
</int>
- <int value="2"
+ <int value="3"
label="Received a captive portal probe result.
(CAPTIVE_PORTAL_PROBE_COMPLETED)">
Was the captive portal probe completed before the interstitial was closed?
Captive Portal won't be detected unless ::Observe is triggered which might
be a few seconds later.
</int>
- <int value="3"
+ <int value="4"
label="Received a captive portal result on an overridable SSL error page
(CAPTIVE_PORTAL_PROBE_COMPLETED_OVERRIDABLE)">
- This is a subset of CAPTIVE_PORTAL_PROBE_COMPLETED (bucket 2), the only
+ This is a subset of CAPTIVE_PORTAL_PROBE_COMPLETED (bucket 3), the only
difference is that it is for overridable errors.
</int>
- <int value="4"
+ <int value="5"
label="Received no response or Non-HTTP login page
(CAPTIVE_PORTAL_NO_RESPONSE)"/>
- <int value="5"
+ <int value="6"
label="Received no response or Non-HTTP login page on an overridable
SSL error page (CAPTIVE_PORTAL_NO_RESPONSE_OVERRIDABLE)"/>
- <int value="6" label="Detected captive portal (CAPTIVE_PORTAL_DETECTED)"/>
- <int value="7"
+ <int value="7" label="Detected captive portal (CAPTIVE_PORTAL_DETECTED)"/>
+ <int value="8"
label="Detected captive portal on an overridable SSL error page
(CAPTIVE_PORTAL_DETECTED_OVERRIDABLE)">
- This is a subset of CAPTIVE_PORTAL_DETECTED (bucket 6), the only difference
+ This is a subset of CAPTIVE_PORTAL_DETECTED (bucket 7), the only difference
is that it is for overridable errors.
</int>
</enum>

Powered by Google App Engine
This is Rietveld 408576698