Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: src/builtins.cc

Issue 91413003: Remove the strict-mode flag from store handlers. It's only relevant to the IC stub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/builtins.h ('k') | src/code-stubs.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1367 matching lines...) Expand 10 before | Expand all | Expand 10 after
1378 static void Generate_KeyedLoadIC_NonStrictArguments(MacroAssembler* masm) { 1378 static void Generate_KeyedLoadIC_NonStrictArguments(MacroAssembler* masm) {
1379 KeyedLoadIC::GenerateNonStrictArguments(masm); 1379 KeyedLoadIC::GenerateNonStrictArguments(masm);
1380 } 1380 }
1381 1381
1382 1382
1383 static void Generate_StoreIC_Slow(MacroAssembler* masm) { 1383 static void Generate_StoreIC_Slow(MacroAssembler* masm) {
1384 StoreIC::GenerateSlow(masm); 1384 StoreIC::GenerateSlow(masm);
1385 } 1385 }
1386 1386
1387 1387
1388 static void Generate_StoreIC_Slow_Strict(MacroAssembler* masm) {
1389 StoreIC::GenerateSlow(masm);
1390 }
1391
1392
1393 static void Generate_StoreIC_Initialize(MacroAssembler* masm) { 1388 static void Generate_StoreIC_Initialize(MacroAssembler* masm) {
1394 StoreIC::GenerateInitialize(masm); 1389 StoreIC::GenerateInitialize(masm);
1395 } 1390 }
1396 1391
1397 1392
1398 static void Generate_StoreIC_Initialize_Strict(MacroAssembler* masm) { 1393 static void Generate_StoreIC_Initialize_Strict(MacroAssembler* masm) {
1399 StoreIC::GenerateInitialize(masm); 1394 StoreIC::GenerateInitialize(masm);
1400 } 1395 }
1401 1396
1402 1397
(...skipping 10 matching lines...) Expand all
1413 static void Generate_StoreIC_Miss(MacroAssembler* masm) { 1408 static void Generate_StoreIC_Miss(MacroAssembler* masm) {
1414 StoreIC::GenerateMiss(masm); 1409 StoreIC::GenerateMiss(masm);
1415 } 1410 }
1416 1411
1417 1412
1418 static void Generate_StoreIC_Normal(MacroAssembler* masm) { 1413 static void Generate_StoreIC_Normal(MacroAssembler* masm) {
1419 StoreIC::GenerateNormal(masm); 1414 StoreIC::GenerateNormal(masm);
1420 } 1415 }
1421 1416
1422 1417
1423 static void Generate_StoreIC_Normal_Strict(MacroAssembler* masm) {
1424 StoreIC::GenerateNormal(masm);
1425 }
1426
1427
1428 static void Generate_StoreIC_Megamorphic(MacroAssembler* masm) { 1418 static void Generate_StoreIC_Megamorphic(MacroAssembler* masm) {
1429 StoreIC::GenerateMegamorphic(masm, kNonStrictMode); 1419 StoreIC::GenerateMegamorphic(masm, kNonStrictMode);
1430 } 1420 }
1431 1421
1432 1422
1433 static void Generate_StoreIC_Megamorphic_Strict(MacroAssembler* masm) { 1423 static void Generate_StoreIC_Megamorphic_Strict(MacroAssembler* masm) {
1434 StoreIC::GenerateMegamorphic(masm, kStrictMode); 1424 StoreIC::GenerateMegamorphic(masm, kStrictMode);
1435 } 1425 }
1436 1426
1437 1427
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
1473 static void Generate_KeyedStoreIC_Miss(MacroAssembler* masm) { 1463 static void Generate_KeyedStoreIC_Miss(MacroAssembler* masm) {
1474 KeyedStoreIC::GenerateMiss(masm); 1464 KeyedStoreIC::GenerateMiss(masm);
1475 } 1465 }
1476 1466
1477 1467
1478 static void Generate_KeyedStoreIC_Slow(MacroAssembler* masm) { 1468 static void Generate_KeyedStoreIC_Slow(MacroAssembler* masm) {
1479 KeyedStoreIC::GenerateSlow(masm); 1469 KeyedStoreIC::GenerateSlow(masm);
1480 } 1470 }
1481 1471
1482 1472
1483 static void Generate_KeyedStoreIC_Slow_Strict(MacroAssembler* masm) {
1484 KeyedStoreIC::GenerateSlow(masm);
1485 }
1486
1487
1488 static void Generate_KeyedStoreIC_Initialize(MacroAssembler* masm) { 1473 static void Generate_KeyedStoreIC_Initialize(MacroAssembler* masm) {
1489 KeyedStoreIC::GenerateInitialize(masm); 1474 KeyedStoreIC::GenerateInitialize(masm);
1490 } 1475 }
1491 1476
1492 1477
1493 static void Generate_KeyedStoreIC_Initialize_Strict(MacroAssembler* masm) { 1478 static void Generate_KeyedStoreIC_Initialize_Strict(MacroAssembler* masm) {
1494 KeyedStoreIC::GenerateInitialize(masm); 1479 KeyedStoreIC::GenerateInitialize(masm);
1495 } 1480 }
1496 1481
1497 1482
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
1660 functions->generator = FUNCTION_ADDR(Generate_##aname); \ 1645 functions->generator = FUNCTION_ADDR(Generate_##aname); \
1661 functions->c_code = NULL; \ 1646 functions->c_code = NULL; \
1662 functions->s_name = #aname; \ 1647 functions->s_name = #aname; \
1663 functions->name = k##aname; \ 1648 functions->name = k##aname; \
1664 functions->flags = Code::ComputeFlags(Code::kind, \ 1649 functions->flags = Code::ComputeFlags(Code::kind, \
1665 state, \ 1650 state, \
1666 extra); \ 1651 extra); \
1667 functions->extra_args = NO_EXTRA_ARGUMENTS; \ 1652 functions->extra_args = NO_EXTRA_ARGUMENTS; \
1668 ++functions; 1653 ++functions;
1669 1654
1670 #define DEF_FUNCTION_PTR_H(aname, kind, extra) \ 1655 #define DEF_FUNCTION_PTR_H(aname, kind) \
1671 functions->generator = FUNCTION_ADDR(Generate_##aname); \ 1656 functions->generator = FUNCTION_ADDR(Generate_##aname); \
1672 functions->c_code = NULL; \ 1657 functions->c_code = NULL; \
1673 functions->s_name = #aname; \ 1658 functions->s_name = #aname; \
1674 functions->name = k##aname; \ 1659 functions->name = k##aname; \
1675 functions->flags = Code::ComputeFlags( \ 1660 functions->flags = Code::ComputeFlags( \
1676 Code::HANDLER, MONOMORPHIC, extra, Code::NORMAL, Code::kind); \ 1661 Code::HANDLER, MONOMORPHIC, Code::kNoExtraICState, \
1662 Code::NORMAL, Code::kind); \
1677 functions->extra_args = NO_EXTRA_ARGUMENTS; \ 1663 functions->extra_args = NO_EXTRA_ARGUMENTS; \
1678 ++functions; 1664 ++functions;
1679 1665
1680 BUILTIN_LIST_C(DEF_FUNCTION_PTR_C) 1666 BUILTIN_LIST_C(DEF_FUNCTION_PTR_C)
1681 BUILTIN_LIST_A(DEF_FUNCTION_PTR_A) 1667 BUILTIN_LIST_A(DEF_FUNCTION_PTR_A)
1682 BUILTIN_LIST_H(DEF_FUNCTION_PTR_H) 1668 BUILTIN_LIST_H(DEF_FUNCTION_PTR_H)
1683 BUILTIN_LIST_DEBUG_A(DEF_FUNCTION_PTR_A) 1669 BUILTIN_LIST_DEBUG_A(DEF_FUNCTION_PTR_A)
1684 1670
1685 #undef DEF_FUNCTION_PTR_C 1671 #undef DEF_FUNCTION_PTR_C
1686 #undef DEF_FUNCTION_PTR_A 1672 #undef DEF_FUNCTION_PTR_A
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
1798 Code** code_address = \ 1784 Code** code_address = \
1799 reinterpret_cast<Code**>(builtin_address(k##name)); \ 1785 reinterpret_cast<Code**>(builtin_address(k##name)); \
1800 return Handle<Code>(code_address); \ 1786 return Handle<Code>(code_address); \
1801 } 1787 }
1802 #define DEFINE_BUILTIN_ACCESSOR_A(name, kind, state, extra) \ 1788 #define DEFINE_BUILTIN_ACCESSOR_A(name, kind, state, extra) \
1803 Handle<Code> Builtins::name() { \ 1789 Handle<Code> Builtins::name() { \
1804 Code** code_address = \ 1790 Code** code_address = \
1805 reinterpret_cast<Code**>(builtin_address(k##name)); \ 1791 reinterpret_cast<Code**>(builtin_address(k##name)); \
1806 return Handle<Code>(code_address); \ 1792 return Handle<Code>(code_address); \
1807 } 1793 }
1808 #define DEFINE_BUILTIN_ACCESSOR_H(name, kind, extra) \ 1794 #define DEFINE_BUILTIN_ACCESSOR_H(name, kind) \
1809 Handle<Code> Builtins::name() { \ 1795 Handle<Code> Builtins::name() { \
1810 Code** code_address = \ 1796 Code** code_address = \
1811 reinterpret_cast<Code**>(builtin_address(k##name)); \ 1797 reinterpret_cast<Code**>(builtin_address(k##name)); \
1812 return Handle<Code>(code_address); \ 1798 return Handle<Code>(code_address); \
1813 } 1799 }
1814 BUILTIN_LIST_C(DEFINE_BUILTIN_ACCESSOR_C) 1800 BUILTIN_LIST_C(DEFINE_BUILTIN_ACCESSOR_C)
1815 BUILTIN_LIST_A(DEFINE_BUILTIN_ACCESSOR_A) 1801 BUILTIN_LIST_A(DEFINE_BUILTIN_ACCESSOR_A)
1816 BUILTIN_LIST_H(DEFINE_BUILTIN_ACCESSOR_H) 1802 BUILTIN_LIST_H(DEFINE_BUILTIN_ACCESSOR_H)
1817 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A) 1803 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A)
1818 #undef DEFINE_BUILTIN_ACCESSOR_C 1804 #undef DEFINE_BUILTIN_ACCESSOR_C
1819 #undef DEFINE_BUILTIN_ACCESSOR_A 1805 #undef DEFINE_BUILTIN_ACCESSOR_A
1820 1806
1821 1807
1822 } } // namespace v8::internal 1808 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/builtins.h ('k') | src/code-stubs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698