runtime/vm/message_queue_test.cc - Issue 9141005: Change the thread interface in runtime/platform and use it starting all threads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/message_queue_test.cc

Issue 9141005: Change the thread interface in runtime/platform and use it starting all threads (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments from ager@ Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/message_queue_test.cc

diff --git a/runtime/vm/message_queue_test.cc b/runtime/vm/message_queue_test.cc

index e807b32d38ee70c48ce079d52326e2f2c5b17c07..8d6fba181a95b8cd001c9165a6626e39b1dc0da9 100644

--- a/runtime/vm/message_queue_test.cc

+++ b/runtime/vm/message_queue_test.cc

@@ -109,8 +109,8 @@ void MessageReceiver_start(uword unused) {

TEST_CASE(MessageQueue_WaitNotify) {

sync = new Monitor();

- Thread* thread = new Thread(MessageReceiver_start, 0);

- EXPECT(thread != NULL);

+ ThreadHandle thread = Thread::Start(MessageReceiver_start, 0);

+ EXPECT(thread != Thread::kInvalidThreadHandle);

// Wait for the shared queue to be created.

while (shared_queue == NULL) {

« runtime/platform/thread_macos.cc ('K') | « runtime/vm/dart_api_impl_test.cc ('k') | runtime/vm/port_test.cc » ('j') | no next file with comments »