runtime/platform/thread_macos.h - Issue 9141005: Change the thread interface in runtime/platform and use it starting all threads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/platform/thread_macos.h

Issue 9141005: Change the thread interface in runtime/platform and use it starting all threads (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments from ager@ Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/platform/thread_macos.h

diff --git a/runtime/platform/thread_macos.h b/runtime/platform/thread_macos.h

index a836dc31aa4f02ccfd1662386f3400e5913382c9..4da05ebfdbc2f8a88fcb0d58ad4737c9ad263806 100644

--- a/runtime/platform/thread_macos.h

+++ b/runtime/platform/thread_macos.h

@@ -15,21 +15,7 @@

namespace dart {

-class ThreadData {

- private:

- ThreadData() {}

- ~ThreadData() {}

- pthread_t* tid() { return &tid_; }

- pthread_t tid_;

- friend class Thread;

- DISALLOW_ALLOCATION();

- DISALLOW_COPY_AND_ASSIGN(ThreadData);

-};

+typedef pthread_t ThreadHandle;

class MutexData {

private:

« runtime/platform/thread_linux.cc ('K') | « runtime/platform/thread_linux.cc ('k') | runtime/platform/thread_macos.cc » ('j') | runtime/platform/thread_macos.cc » ('J')