runtime/vm/port_test.cc - Issue 9141005: Change the thread interface in runtime/platform and use it starting all threads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/port_test.cc

Issue 9141005: Change the thread interface in runtime/platform and use it starting all threads (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments from asiva@ Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/port_test.cc

diff --git a/runtime/vm/port_test.cc b/runtime/vm/port_test.cc

index 3ffc81bed87afbefbc86ad496d315b62b96887ef..7e19f154c02dc1b55ff4c4898558f5841ea12156 100644

--- a/runtime/vm/port_test.cc

+++ b/runtime/vm/port_test.cc

@@ -235,8 +235,8 @@ void ThreadedPort_start(uword parameter) {

TEST_CASE(ThreadedPort) {

intptr_t local = PortMap::CreatePort();

- Thread* thr = new Thread(ThreadedPort_start, local);

- EXPECT(thr != NULL);

+ int result = Thread::Start(ThreadedPort_start, local);

+ EXPECT_EQ(0, result);

PortMessage* msg = NextMessage();

EXPECT_EQ(local, msg->dest_port());

« runtime/bin/thread_pool.cc ('K') | « runtime/vm/message_queue_test.cc ('k') | no next file » | no next file with comments »