Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Unified Diff: runtime/lib/isolate.cc

Issue 9141005: Change the thread interface in runtime/platform and use it starting all threads (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments from asiva@ Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/isolate.cc
diff --git a/runtime/lib/isolate.cc b/runtime/lib/isolate.cc
index 75a9a34c3622a3671c7fcc314fd4d9e513482b8e..437769e8e54f6bff0691a166a67ecd7e8cae324e 100644
--- a/runtime/lib/isolate.cc
+++ b/runtime/lib/isolate.cc
@@ -298,7 +298,10 @@ DEFINE_NATIVE_ENTRY(IsolateNatives_start, 2) {
strdup(library_url),
strdup(class_name),
port_id));
- new Thread(RunIsolate, data);
+ int result = Thread::Start(RunIsolate, data);
+ if (result != 0) {
+ FATAL1("Failed to start isolate thread %d", result);
+ }
} else {
// Error spawning the isolate, maybe due to initialization errors or
// errors while loading the application into spawned isolate, shut

Powered by Google App Engine
This is Rietveld 408576698