Change the thread interface in runtime/platform and use it starting all threads

runtime/platform/thread.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef PLATFORM_THREAD_H_
 #define PLATFORM_THREAD_H_
 
 #include "platform/globals.h"
 
 // Declare the OS-specific types ahead of defining the generic classes.
 #if defined(TARGET_OS_LINUX)
 #include "platform/thread_linux.h"
 #elif defined(TARGET_OS_MACOS)
 #include "platform/thread_macos.h"
 #elif defined(TARGET_OS_WINDOWS)
 #include "platform/thread_win.h"
 #else
 #error Unknown target os.
 #endif
 
 namespace dart {
 
 class Thread {
  public:
-  // Function to be called on thread start.
+  static const int64_t kNoTimeout = 0;
+  static const ThreadHandle kInvalidThreadHandle;
+
   typedef void (*ThreadStartFunction) (uword parameter);
 
-  // TODO(iposva): Define the proper interface for spawning and killing threads.
-  Thread(ThreadStartFunction function, uword parameters);
-  ~Thread();
-
- private:
-  ThreadData data_;
-
-  DISALLOW_COPY_AND_ASSIGN(Thread);
+  // Start a thread running the specified function.
+  static ThreadHandle Start(ThreadStartFunction function, uword parameters);
+  // Wait for thread termination or timeout.
+  static void Join(ThreadHandle thread);

[Ivan Posva, 2012/01/20 16:45:55]

Please remove the Join functionality it is not really useful. That will also
remove the need for defining and returning a ThreadHandle.

[Søren Gjesse, 2012/01/23 13:14:58]

Why is Join not useful? Especially for testing I have found that if a test uses
a number of threads to do something then just joining with all the threads on
the main thread works nicely. Without Join some other synchronization mechanism
will be needed for that.

I missed that the pthreads created by to VM where detached by default whereas
the ones used by the eventhandler and thread pool here joinable (not using this
shared code before).

I have added a flag to Start for specified joinable - that might be an option.

 };
 
 
 class Mutex {
  public:
   Mutex();
   ~Mutex();
 
   void Lock();
   bool TryLock();
@@ skipping 31 matching lines @@
  private:
   MonitorData data_;  // OS-specific data.
 
   DISALLOW_COPY_AND_ASSIGN(Monitor);
 };
 
 }  // namespace dart
 
 
 #endif  // PLATFORM_THREAD_H_