Change the thread interface in runtime/platform and use it starting all threads

runtime/vm/port_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/message_queue.h"
 #include "vm/os.h"
 #include "vm/port.h"
 #include "vm/unit_test.h"
 
@@ skipping 217 matching lines @@
   }
   PortMap::PostMessage(remote, 0, AllocIntData(kEOT));
 
   Dart::ShutdownIsolate();
 }
 
 
 TEST_CASE(ThreadedPort) {
   intptr_t local = PortMap::CreatePort();
 
-  Thread* thr = new Thread(ThreadedPort_start, local);
-  EXPECT(thr != NULL);
+  int result = Thread::Start(ThreadedPort_start, local);
+  EXPECT_EQ(0, result);
 
   PortMessage* msg = NextMessage();
   EXPECT_EQ(local, msg->dest_port());
   EXPECT(msg != NULL);
   intptr_t remote = GetIntData(msg->data());  // Get the remote port.
   delete msg;
 
   for (intptr_t i = 0; i < 10; i++) {
     PortMap::PostMessage(remote, 0, AllocIntData(i));
     PortMessage* msg = NextMessage();
@@ skipping 13 matching lines @@
   // Give the spawned thread enough time to properly exit.
   Monitor* waiter = new Monitor();
   {
     MonitorLocker ml(waiter);
     ml.Wait(20);
   }
   delete waiter;
 }
 
 }  // namespace dart