Change the thread interface in runtime/platform and use it starting all threads

runtime/platform/thread_win.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/thread.h"
 
 #include <process.h>
 
 #include "platform/assert.h"
 
 namespace dart {
 
 class ThreadStartData {
  public:
   ThreadStartData(Thread::ThreadStartFunction function,
                   uword parameter,
-                  Thread* thread)
-      : function_(function), parameter_(parameter), thread_(thread) {}
+                  bool joinable)

[Ivan Posva, 2012/01/24 02:04:01]

joinable is a thing of the past.

[Søren Gjesse, 2012/01/24 12:07:55]

Sorry, did not test this change on Windows.

+      : function_(function), parameter_(parameter), joinable_(joinable) {}
 
   Thread::ThreadStartFunction function() const { return function_; }
   uword parameter() const { return parameter_; }
-  Thread* thread() const { return thread_; }
 
  private:
   Thread::ThreadStartFunction function_;
   uword parameter_;
-  Thread* thread_;
+  bool joinable_;
 
   DISALLOW_COPY_AND_ASSIGN(ThreadStartData);
 };
 
 
 // Dispatch to the thread start function provided by the caller. This trampoline
 // is used to ensure that the thread is properly destroyed if the thread just
 // exits.
 static unsigned int __stdcall ThreadEntry(void* data_ptr) {
   ThreadStartData* data =  reinterpret_cast<ThreadStartData*>(data_ptr);
 
   Thread::ThreadStartFunction function = data->function();
   uword parameter = data->parameter();
-  Thread* thread = data->thread();
   delete data;
 
   // Call the supplied thread start function handing it its parameters.
   function(parameter);
 
-  // When the function returns here, make sure that the thread is deleted.
-  delete thread;
+  // When the function returns here close the handle.
+  CloseHandle(GetCurrentThread());
 
   return 0;
 }
 
 
-Thread::Thread(ThreadStartFunction function, uword parameter) {
-  ThreadStartData* start_data = new ThreadStartData(function, parameter, this);
+ThreadHandle Thread::Start(ThreadStartFunction function, uword parameter) {
+  ThreadStartData* start_data = new ThreadStartData(
+      function, parameter, (flags & kJoinable) != 0);
   uint32_t tid;
-  data_.thread_handle_ =
-    _beginthreadex(NULL, 64 * KB, ThreadEntry, start_data, 0, &tid);
-  if (data_.thread_handle_ == -1) {
+  uintptr_t thread =
+      _beginthreadex(NULL, 64 * KB, ThreadEntry, start_data, 0, &tid);
+  if (thread == kInvalidThreadHandle) {
     FATAL("Thread creation failed");
   }
-  data_.tid_ = tid;
 }
 
 
-Thread::~Thread() {
-  CloseHandle(reinterpret_cast<HANDLE>(data_.thread_handle_));
-}
-
-
 Mutex::Mutex() {
   // Allocate unnamed semaphore with initial count 1 and max count 1.
   data_.semaphore_ = CreateSemaphore(NULL, 1, 1, NULL);
   if (data_.semaphore_ == NULL) {
     FATAL("Mutex allocation failed");
   }
 }
 
 
 Mutex::~Mutex() {
@@ skipping 82 matching lines @@
 void Monitor::Notify() {
   WakeConditionVariable(&data_.cond_);
 }
 
 
 void Monitor::NotifyAll() {
   WakeAllConditionVariable(&data_.cond_);
 }
 
 }  // namespace dart