Adds a 'webkit_lint' test step to the bots

scripts/slave/chromium_commands.py

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A subclass of commands.SVN that allows more flexible error recovery.
 
 This code is only used on the slave but it is living in common/ because it is
 directly imported from buildbot/slave/bot.py."""
 
 import os
@@ skipping 125 matching lines @@
   # pylint complains that __init__ in GClient's parent isn't called.  This is
   # because it doesn't realize we call it through GetParentClass().  Disable
   # that warning next.
   # pylint: disable=W0231
 
   header = 'gclient'
 
   def __init__(self, *args, **kwargs):
     # TODO(maruel): Mainly to keep pylint happy, remove once buildbot fixed
     # their style.
-    self.branch = None
     self.srcdir = None
     self.revision = None
     self.env = None
     self.sourcedatafile = None
     self.patch = None
     self.command = None
     self.vcexe = None
     self.svnurl = None
     self.sudo_for_remove = None
     self.gclient_spec = None
@@ skipping 113 matching lines @@
     command = [chromium_utils.GetGClientCommand(),
                'sync', '--verbose', '--reset', '--manually_grab_svn_rev',
                '--delete_unversioned_trees']
     # Don't run hooks if it was patched or there is a patch since runhooks will
     # be run after.
     if self.gclient_nohooks or self.patch or self.was_patched:
       command.append('--nohooks')
     # GClient accepts --revision argument of two types 'module@rev' and 'rev'.
     if self.revision:
       command.append('--revision')
-      if (not self.branch or
-          self.no_gclient_branch or
-          '@' in str(self.revision)):
-        command.append(str(self.revision))
-      else:
-        # Make the revision look like branch@revision.
-        command.append('%s@%s' % (self.branch, self.revision))
+      command.append(str(self.revision))

[nsylvain, 2012/01/25 20:19:54]

do you really want to touch this? or is this a rebase problem?

[Dirk Pranke, 2012/01/25 22:39:07]

Change contamination :( Reverted.

       # We only add the transitive flag if we have a revision, otherwise it is
       # meaningless.
       if self.gclient_transitive:
         command.append('--transitive')
 
     if self.gclient_deps:
       command.append('--deps=' + self.gclient_deps)
 
     c = runprocesscmd(self.builder, command, dirname,
                       sendRC=False, timeout=self.timeout,
@@ skipping 140 matching lines @@
                       initialStdin=diff, environ=self.env)
     self.command = c
     d = c.start()
     d.addCallback(self._abandonOnFailure)
     if diff.find('DEPS') != -1:
       d.addCallback(self.doVCUpdateOnPatch)
       d.addCallback(self._abandonOnFailure)
     return d
 
   def doVCUpdateOnPatch(self, res):
-    if self.revision and not self.branch and '@' not in str(self.revision):
+    if self.revision:
       self.branch = 'src'
     return self.doVCUpdate()
 
   def doRunHooks(self, dummy):
     """Runs "gclient runhooks" after patching."""
     dirname = os.path.join(self.builder.basedir, self.srcdir)
     command = [chromium_utils.GetGClientCommand(), 'runhooks']
     c = runprocesscmd(self.builder, command, dirname,
                       sendRC=False, timeout=self.timeout,
                       keepStdout=True, environ=self.env)
@@ skipping 144 matching lines @@
     # This version should work on BB 7.12
 
     # We run this code in a try because it fails with an assertion if
     # the module is loaded twice.
     registerSlaveCommand('gclient', GClient, commands.command_version)
   except (AssertionError, NameError):
     pass
 
 
 RegisterGclient()