Adds a 'webkit_lint' test step to the bots

scripts/master/factory/chromium_factory.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Utility class to build the chromium master BuildFactory's.
 
 Based on gclient_factory.py and adds chromium-specific steps."""
 
 import os
 import re
@@ skipping 302 matching lines @@
 
     if R('installer'):      f.AddInstallerTests(fp)
 
     # WebKit-related tests:
     if R('webkit_unit'):    f.AddBasicGTestTestStep('webkit_unit_tests', fp)
     if R('webkit'):         f.AddWebkitTests(gpu=False,
                                              factory_properties=fp)
     if R('devtools_perf'):  f.AddDevToolsTests(factory_properties=fp)
     if R('webkit_gpu'):     f.AddWebkitTests(gpu=True,
                                              factory_properties=fp)
+    if R('webkit_lint'):    f.AddWebkitLint(factory_properties=fp)

[nsylvain, 2012/01/25 20:19:54]

if you want to run "before" the webkit tests, you probably want to move this
line before.  The test=[] order is not kept, it's the order in this function
that matters.

[Dirk Pranke, 2012/01/25 22:39:07]

Ah, good to know. Yes, I want it to run before. Fixed.

 
     # Benchmark tests:
     if R('page_cycler_moz'):
       f.AddPageCyclerTest('page_cycler_moz', fp)
     if R('page_cycler_morejs'):
       f.AddPageCyclerTest('page_cycler_morejs', fp)
     if R('page_cycler_intl1'):
       f.AddPageCyclerTest('page_cycler_intl1', fp)
     if R('page_cycler_intl2'):
       f.AddPageCyclerTest('page_cycler_intl2', fp)
@@ skipping 537 matching lines @@
     if 'cros_deps' not in [s.name for s in self._solutions]:
       self._solutions.append(gclient_factory.GClientSolution(
           config.Master.trunk_url + '/src/tools/cros.DEPS', name='cros_deps'))
     if 'asan.DEPS' not in [s.name for s in self._solutions]:
       self._solutions.append(gclient_factory.GClientSolution(
           'http://src.chromium.org/svn/trunk/deps/asan.DEPS',
           'asan.DEPS'))
     return self.ChromiumFactory(target, clobber, tests, mode, slave_type,
                                 options, compile_timeout, build_url, project,
                                 factory_properties)