Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 9138015: Enable asynchronous remote debugging with d8. (Closed)

Created:
8 years, 11 months ago by Yang
Modified:
8 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Enable asynchronous remote debugging with d8. BUG=v8:1691 TEST= Committed: https://code.google.com/p/v8/source/detail?r=10454

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M src/d8.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/d8.cc View 3 chunks +14 lines, -1 line 2 comments Download
M src/d8-readline.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
when running instance A of d8 as debugging agent in the interactive shell and instance ...
8 years, 11 months ago (2012-01-20 11:47:25 UTC) #1
Jakob Kummerow
LGTM http://codereview.chromium.org/9138015/diff/1/src/d8.cc File src/d8.cc (right): http://codereview.chromium.org/9138015/diff/1/src/d8.cc#newcode615 src/d8.cc:615: printf("message trying to be dispatched\n"); intentional?
8 years, 11 months ago (2012-01-20 11:53:31 UTC) #2
Yang
8 years, 11 months ago (2012-01-20 11:59:51 UTC) #3
http://codereview.chromium.org/9138015/diff/1/src/d8.cc
File src/d8.cc (right):

http://codereview.chromium.org/9138015/diff/1/src/d8.cc#newcode615
src/d8.cc:615: printf("message trying to be dispatched\n");
On 2012/01/20 11:53:31, Jakob wrote:
> intentional?

Forgot to remove this debug message. Done.

Powered by Google App Engine
This is Rietveld 408576698