Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 9138009: Fix crash in extension_custom_bindings.js by defining WINDOW_ID_NONE locally (Closed)

Created:
8 years, 11 months ago by not at google - send to devlin
Modified:
8 years, 11 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org, jstritar, Mihai Parparita -not on Chrome
Visibility:
Public.

Description

Fix crash in extension_custom_bindings.js by defining WINDOW_ID_NONE locally rather than looking up chrome.windows. BUG=110694 TEST=as in bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118573

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/renderer/resources/extensions/extension_custom_bindings.js View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
not at google - send to devlin
Temporary measure to fix bug. Or maybe not.
8 years, 11 months ago (2012-01-20 07:04:02 UTC) #1
Aaron Boodman
On 2012/01/20 07:04:02, kalman wrote: > Temporary measure to fix bug. > > Or maybe ...
8 years, 11 months ago (2012-01-20 07:08:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/9138009/1
8 years, 11 months ago (2012-01-20 07:33:09 UTC) #3
commit-bot: I haz the power
Try job failure for 9138009-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 11 months ago (2012-01-20 09:48:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/9138009/1
8 years, 11 months ago (2012-01-20 12:58:53 UTC) #5
commit-bot: I haz the power
8 years, 11 months ago (2012-01-20 19:01:25 UTC) #6
The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac_rel, revision is 118459, job name
was 9138009-1 (retry) (retry) (retry) (previous was lost).

Powered by Google App Engine
This is Rietveld 408576698