Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 913733003: Add guideline for {} in interpolation (Closed)

Created:
5 years, 10 months ago by Kathy Walrath
Modified:
5 years, 10 months ago
Reviewers:
*Bob Nystrom
Base URL:
https://github.com/dart-lang/www.dartlang.org.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Move the guidelines to a new Strings section #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M src/site/articles/style-guide/index.markdown View 1 3 chunks +26 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Kathy Walrath
I couldn't think of an ideal place for this, since it doesn't seem to fall ...
5 years, 10 months ago (2015-02-10 17:48:35 UTC) #3
Bob Nystrom
On 2015/02/10 17:48:35, Kathy Walrath wrote: > I couldn't think of an ideal place for ...
5 years, 10 months ago (2015-02-13 17:38:31 UTC) #4
pquitslund
On 2015/02/13 17:38:31, Bob Nystrom wrote: > On 2015/02/10 17:48:35, Kathy Walrath wrote: > > ...
5 years, 10 months ago (2015-02-13 18:01:15 UTC) #5
Bob Nystrom
On 2015/02/13 18:01:15, pquitslund wrote: > On 2015/02/13 17:38:31, Bob Nystrom wrote: > > On ...
5 years, 10 months ago (2015-02-13 18:11:49 UTC) #6
Kathy Walrath
> Maybe add a section for "strings"? We've have requests for style guidance for > ...
5 years, 10 months ago (2015-02-13 23:50:35 UTC) #7
Bob Nystrom
lgtm
5 years, 10 months ago (2015-02-17 17:47:42 UTC) #8
Kathy Walrath
5 years, 10 months ago (2015-02-17 18:11:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cd9f1a4d3fa305a14d4cd55f51632361120c4117 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698